feat(v3): generate Linux hicolor icons - #5918
Open
mortenolsrud wants to merge 1 commit into
Open
Conversation
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-linuxoutputdirand independent-linuxsizesflags towails3 generate iconsupdate build-assetsdetects an older Taskfile that cannot generate the new filesCompatibility
The existing Windows/macOS options and ICO
-sizesparsing are unchanged. Raw Linux generation is opt-in. Fresh projects receive the new Taskfile and package mappings; existing projects keep packageable legacy behavior until their preserved Taskfile declares the complete default Linux set.The portable directory swap is recoverable rather than a lock-protected atomic exchange: readers may briefly see the output directory absent between renames, but they never see partially written PNGs, and the next invocation restores the previous complete set after interruption.
Verification
go test ./internal/commands ./internal/packager -count=1go test -racefor Linux generation and build-asset compatibilitygo vet ./internal/commandsdeb,rpm, andarchlinuxgit diff --checkCloses #5917.
Related to #4025.