Skip to content

fix: use InvalidStateError for non-fully-active document checks #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoscaceres merged 3 commits into from
Mar 26, 2026
Merged

fix: use InvalidStateError for non-fully-active document checks #1056

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a1372d
fix: use InvalidStateError for non-fully-active document checks
marcoscaceres Mar 2, 2026
9fe4704
Add Aborts for when transitioned to non-fully-active
marcoscaceres Mar 3, 2026
0f898c0
Check canMakePayment
marcoscaceres Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 35 additions & 7 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,7 @@ <h2>
</li>
<li data-tests="rejects_if_not_active.https.html">If |document| is
not [=Document/fully active=], then return <a>a promise rejected
with</a> an {{"AbortError"}} {{DOMException}}.
with</a> an {{"InvalidStateError"}} {{DOMException}}.
</li>
<li>If |document|'s [=Document/visibility state=] is not `"visible"`,
then return <a>a promise rejected with</a> an {{"AbortError"}}
Expand Down Expand Up @@ -1331,9 +1331,17 @@ <h2>
<ol>
<li>Close down the user interface.
</li>
<li>Set |request|.{{PaymentRequest/[[state]]}} to
Comment thread
marcoscaceres marked this conversation as resolved.
"[=PaymentRequest/closed=]".
</li>
<li>Set |request|'s <a>payment-relevant browsing context</a>'s
<a>payment request is showing</a> boolean to false.
</li>
<li>
<a>Queue a task</a> on the <a>user interaction task source</a>
to [=reject=] |acceptPromise| with an {{"AbortError"}}
{{DOMException}}.
</li>
</ol>
</li>
</ol>
Expand Down Expand Up @@ -2488,7 +2496,7 @@ <h2>
<li data-tests=
"payment-response/rejects_if_not_active-manual.https.html">If
|document| is not [=Document/fully active=], then return <a>a promise
rejected with</a> an {{"AbortError"}} {{DOMException}}.
rejected with</a> an {{"InvalidStateError"}} {{DOMException}}.
</li>
<li>If |response|.{{PaymentResponse/[[complete]]}} is true, return
<a>a promise rejected with</a> an {{"InvalidStateError"}}
Expand Down Expand Up @@ -2589,9 +2597,17 @@ <h2>
<ol>
<li>Close down the user interface.
</li>
<li>Set |request|.{{PaymentRequest/[[state]]}} to
"[=PaymentRequest/closed=]".
</li>
<li>Set |request|'s <a>payment-relevant browsing context</a>'s
<a>payment request is showing</a> boolean to false.
</li>
<li>
<a>Queue a task</a> on the <a>user interaction task source</a>
to [=reject=] |retryPromise| with an {{"AbortError"}}
{{DOMException}}.
</li>
</ol>
</li>
<li>Finally, when |retryPromise| settles, set
Expand Down Expand Up @@ -2920,6 +2936,11 @@ <h2>
<li>Set |request|'s <a>payment-relevant browsing context</a>'s
<a>payment request is showing</a> boolean to false.
</li>
<li>
<a>Queue a task</a> on the <a>user interaction task source</a>
to [=reject=] |promise| with an {{"AbortError"}}
{{DOMException}}.
</li>
</ol>
</li>
<li>Otherwise:
Expand Down Expand Up @@ -3504,6 +3525,13 @@ <h2>
"[=PaymentRequest/created=]", then return <a>a promise rejected
with</a> an {{"InvalidStateError"}} {{DOMException}}.
</li>
<li>Let |document| be |request|'s [=relevant global object=]'s
[=associated `Document`=].
</li>
<li>If |document| is not [=Document/fully active=], then return
<a>a promise rejected with</a> an {{"InvalidStateError"}}
{{DOMException}}.
</li>
<li data-tests="">Optionally, at the <a>top-level browsing
context</a>'s discretion, return <a>a promise rejected with</a> a
{{"NotAllowedError"}} {{DOMException}}.
Expand Down Expand Up @@ -4430,11 +4458,11 @@ <h2 id="user-info">
data models used by existing payment methods, prescribing data
specifics in this API would limit its usefulness. The
{{PaymentResponse/details}} member carries data from the payment
handler, whether Web-based (as defined by the [[[web-based-payment-handler]]])
or proprietary. The [=user agent=] MUST NOT support payment handlers
unless they include adequate user consent mechanisms (such as
awareness of parties to the transaction and mechanisms for
demonstrating the intention to share data).
handler, whether Web-based (as defined by the
[[[web-based-payment-handler]]]) or proprietary. The [=user agent=]
MUST NOT support payment handlers unless they include adequate user
consent mechanisms (such as awareness of parties to the transaction
and mechanisms for demonstrating the intention to share data).
</p>
<p>
The <a>user agent</a> MUST NOT share the values of the
Expand Down