Conversation
apasel422
force-pushed
the
sim
branch
2 times, most recently
from
a2cfc4f to
dacefe1
Compare
apasel422
commented
Feb 23, 2026
apasel422
force-pushed
the
sim
branch
2 times, most recently
from
87c65fa to
efc0b2f
Compare
bmcase
reviewed
Apr 13, 2026
Contributor
bmcase
left a comment
bmcase
left a comment
There was a problem hiding this comment.
checked over the main privacy budget related functions and compared with the safety limits PR. Looks good; left a couple comments.
bmcase
reviewed
Apr 13, 2026
apasel422
force-pushed
the
sim
branch
2 times, most recently
from
abd1515 to
98fbc97
Compare
bmcase
reviewed
Apr 21, 2026
bmcase
reviewed
Apr 21, 2026
bmcase
reviewed
Apr 21, 2026
bmcase
approved these changes
Apr 21, 2026
Contributor
bmcase
left a comment
bmcase
left a comment
There was a problem hiding this comment.
this is looking good to me; we should still add some more tests that push against the edges of the updated privacy budgeting logic but we can probably follow up with those in a separate PR.
martinthomson
approved these changes
Apr 28, 2026
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
Looks like a pretty direct translation to me. A few comments, but mostly down to your discretion about how you deal with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding to #309 and #403.