Skip to content

T8966: add legacy-label escape to invalid-task-id rule (commit check exempt)#112

Merged
andamasov merged 1 commit into
rollingfrom
feat/T8966-legacy-escape
Jun 7, 2026
Merged

T8966: add legacy-label escape to invalid-task-id rule (commit check exempt)#112
andamasov merged 1 commit into
rollingfrom
feat/T8966-legacy-escape

Conversation

@andamasov

Copy link
Copy Markdown
Member

Adds a maintainer-controlled legacy label escape to the per-repo T-ID rule (toggles invalid-task-id). The PR title check stays enforced for every PR; the per-commit check is exempted when a PR carries the legacy label — an escape hatch for grandfathered PRs whose commit history cannot be rewritten (repos that squash-merge and block force-push). Pilot verified on vyos/vyos.vyos. Change-management: IS-539. Tracked under T8966.

🤖 Generated by robots

@andamasov andamasov merged commit 5b4d6d2 into rolling Jun 7, 2026
0 of 3 checks passed
@andamasov andamasov deleted the feat/T8966-legacy-escape branch June 7, 2026 22:50
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 820c983e-a33e-4dad-aa06-5d1eae223524

📥 Commits

Reviewing files that changed from the base of the PR and between e018142 and 353e66c.

📒 Files selected for processing (1)
  • .github/mergify.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated PR validation rules to exclude legacy-labeled pull requests from commit message format enforcement.

Walkthrough

Mergify rule for commit-message T-ID format validation updated to exclude PRs with the legacy label. The existing negative-regex check remains unchanged but is now combined with a label!=legacy condition in an and: block.

Changes

Mergify Rule Configuration

Layer / File(s) Summary
T-ID format rule legacy exclusion
.github/mergify.yml
The "Flag product T-ID format violation" rule condition is refactored to exclude PRs labeled legacy by wrapping the existing commit-message pattern check inside an and: condition alongside label!=legacy.

Possibly related PRs

  • vyos/vyos-cloud-init#110: Both PRs modify .github/mergify.yml to handle the invalid-task-id label in relation to T-ID title/commit checks; the main PR gates this rule with label!=legacy.
  • vyos/vyos-cloud-init#101: Modifies .github/mergify.yml Mergify rule configuration for PR enforcement, including T-ID format checks that this PR now gates.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/T8966-legacy-escape

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the rolling label Jun 7, 2026
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed This PR has been mirrored successfully and removed mirror-initiated This PR initiated for mirror sync workflow labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mirror-completed This PR has been mirrored successfully rolling

Development

Successfully merging this pull request may close these issues.

1 participant