Skip to content

fix(test-env): format WireMock catalog fixture (fixes red CI on main)#19

Merged
stephane-segning merged 1 commit into
mainfrom
fix/format-test-env-fixtures
May 29, 2026
Merged

fix(test-env): format WireMock catalog fixture (fixes red CI on main)#19
stephane-segning merged 1 commit into
mainfrom
fix/format-test-env-fixtures

Conversation

@stephane-segning
Copy link
Copy Markdown
Contributor

Summary

main CI went red after #18 merged — the Format check step fails on both Node 22 and 24 (run).

Root cause: test-env/wiremock/__files/openrouter-catalog.json had multi-line supported_parameters arrays that Biome collapses onto a single line. CI scans the whole repo (62 files) and flagged it; this PR runs biome format --write on it.

Why it slipped through

biome.json excludes **/.claude, and the dev worktree lives under .claude/worktrees/<id>/. Running pnpm format:check from inside a worktree therefore matches zero files and exits 0 — so the local gate was a no-op for files added in this session. The package-scoped format runs covered packages/* but not the workspace-root test-env/ fixtures.

Verification

  • pnpm exec biome format packages/ test-env/ -> 59 files, clean.
  • Only the one fixture file changes (whitespace; no behavioral change to the stub responses).

Follow-up (not in this PR)

Make format:check/lint robust to worktree CWD so this class of failure can't pass locally again.

🤖 Generated with Claude Code

The OpenRouter catalog fixture had multi-line `supported_parameters`
arrays that Biome collapses to a single line. CI's `format:check` scans
the whole repo (62 files) and caught it on main after #18 merged.

It slipped through locally because biome.json excludes `**/.claude`, and
the dev worktree lives under `.claude/worktrees/<id>/` — so
`pnpm format:check` from a worktree reports "no files processed" and
exits 0. (Tracked separately: make the format/lint scripts robust to
worktree CWD.)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request formats the 'supported_parameters' arrays in the 'openrouter-catalog.json' mock file to be single-line arrays instead of multi-line arrays. There are no review comments to address, and I have no additional feedback to provide.

@stephane-segning stephane-segning merged commit 264659b into main May 29, 2026
3 checks passed
@stephane-segning stephane-segning deleted the fix/format-test-env-fixtures branch May 29, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant