fix(test-env): format WireMock catalog fixture (fixes red CI on main)#19
Merged
Merged
Conversation
The OpenRouter catalog fixture had multi-line `supported_parameters` arrays that Biome collapses to a single line. CI's `format:check` scans the whole repo (62 files) and caught it on main after #18 merged. It slipped through locally because biome.json excludes `**/.claude`, and the dev worktree lives under `.claude/worktrees/<id>/` — so `pnpm format:check` from a worktree reports "no files processed" and exits 0. (Tracked separately: make the format/lint scripts robust to worktree CWD.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI went red after #18 merged — the Format check step fails on both Node 22 and 24 (run).Root cause:
test-env/wiremock/__files/openrouter-catalog.jsonhad multi-linesupported_parametersarrays that Biome collapses onto a single line. CI scans the whole repo (62 files) and flagged it; this PR runsbiome format --writeon it.Why it slipped through
biome.jsonexcludes**/.claude, and the dev worktree lives under.claude/worktrees/<id>/. Runningpnpm format:checkfrom inside a worktree therefore matches zero files and exits 0 — so the local gate was a no-op for files added in this session. The package-scopedformatruns coveredpackages/*but not the workspace-roottest-env/fixtures.Verification
pnpm exec biome format packages/ test-env/-> 59 files, clean.Follow-up (not in this PR)
Make
format:check/lintrobust to worktree CWD so this class of failure can't pass locally again.🤖 Generated with Claude Code