fix(VDataTableVirtual): avoid scroll glitches with expanded rows#23014
Draft
J-Sek wants to merge 1 commit into
Draft
fix(VDataTableVirtual): avoid scroll glitches with expanded rows#23014J-Sek wants to merge 1 commit into
J-Sek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20457
related to: #22938
TODO:
Problem: The expanded
<tr>was never measured, sosizes[index]under-counted and every scrolloffset above an expanded row was wrong
watchto measure the expanded row. It now renders inside its ownVVirtualScrollItemvirtualIndex(flat position)expanded/expanded-rowslots are omitted fromVDataTableRowssince they're now rendered — and measured — in the item slot.#expandedslot is preservedThe
expanded-rowslot stays conditionally rendered with the measurement ref attached automatically viacloneVNode, so we do not force users to attachitemRefpassed via slot props.Markup: