Add Treact changes - #6
Merged
Merged
Conversation
Made-with: Cursor
Collaborator
|
I think this looks good! @drhcelik can you confirm and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An optional temperature threshold
Treactwas added to skip the chemistry solve when the temperature of the cell is smaller thanTreact.Treactis provided viachemistryPropertiesdictionary, read bymakeEvaluatorfunction and passed to the constructors ofGpuKernelEvaluatorandsingleCellSolver.The data of chemical-frozen cell is still sent to GPU in this revision.