Fix species naming in GPU chemistry model to compile on latest OF dev - #3
Closed
drhcelik wants to merge 2 commits into
Closed
Fix species naming in GPU chemistry model to compile on latest OF dev#3drhcelik wants to merge 2 commits into
drhcelik wants to merge 2 commits into
Conversation
Collaborator
|
Can you check what's wrong with the build? Is the image we test against up to date? |
Collaborator
Author
|
It seems like the image we test against is not up to date. |
Collaborator
|
@drhcelik do you think you could update the image so we can get this merged? For the long term it may be better to use some public image but then we need a place to run the tests. I think microsoft has some machines available for open source projects for testing but I doubt they have gpus. There is really no point in running the tests without a gpu |
Collaborator
Author
|
@hamsteri15 I think Timo updated the image, but it looks like the unit tests are failing. |
Collaborator
|
The issue is that the old NA is nowadays NNA. gpuNA should be renamed gpuNNA and gpuRR should use that. Then the test could be made against NNA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified to compile on latest dev.