test: let the mock hold the installed modules - #12
Merged
Merged
Conversation
The update-check test built `game.modules` by hand, because the mock's answered `get` and `has` and the checker walks the list. `@vttforge/testing` 0.14.0 takes the modules as an option, so the hand-built collection is gone and the handles are passed straight in. `Handle` became a type rather than an interface. `MockModuleOptions` carries an index signature, and an interface does not satisfy one. Same handles, same 40 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update-check test built
game.modulesby hand — a Map wrapped inget,has,valuesandsize— because the mock's collection answeredgetandhasand the checker walks the list.@vttforge/testing0.14.0 takes the modules as an option, so that helper is gone:One thing worth naming for the next person:
Handlehad to become atyperather than aninterface.MockModuleOptionscarries an index signature and an interface does not satisfy one, so the call failed to compile until it changed. The error message says it, but it reads like a puzzle the first time.Same handles, same 40 tests.
pnpm run typecheckandpnpm run lintare clean.