chore(release): 0.2.1, cut by the merge - #10
Merged
Merged
Conversation
Documentation only. No code that runs in Foundry changed since 0.2.0. The zip on the current release carries the old README: no screenshots, and a macro example that throws when pasted. Foundry points at that README from the manifest, so what ships in the package is what people read.
A push to main whose package.json version has no tag yet builds the zip, creates the tag and opens the release. A version already tagged does nothing, so every other merge is a no-op and a re-run is harmless. The v* trigger stays for what the merge cannot cover: re-cutting a release that failed halfway, and tagging an older commit. A tag pushed by this workflow does not start a second run, because GitHub does not trigger workflows on its own token. Typecheck and the unit tests run before the build. CI covers every pull request; this covers what is about to be handed to people.
fcsouza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things: the 0.2.1 version bump, and the workflow change that makes the merge cut the release.
Why the release exists
Documentation only. No code that runs in Foundry changed since 0.2.0: the only files under
scripts/since that tag are tests, and those do not ship.module.jsonpointsreadmeat a path inside the module folder, so Foundry reads the README out of the installed package. The zip on the current release carries the old one: no screenshots, headings written for developers, and a macro example that throws when pasted because it declares the same name twice.Why the workflow changes
Releasing meant remembering to push a tag by hand. Now a push to main whose
package.jsonversion has no tag yet builds the zip, creates the tag and opens the release. A version that is already tagged does nothing, so every other merge is a no-op and a re-run is harmless.The
v*trigger stays for what the merge cannot cover: re-cutting a release that failed halfway, and tagging an older commit. A tag pushed by this workflow does not start a second run, because GitHub does not trigger workflows on its own token.Typecheck and the unit tests now run before the build. CI covers every pull request; this covers what is about to be handed to people.
Checked
The version resolution ran locally in all four paths:
package.json0.2.1, tag absentversion=0.2.1 skip=falseskip=true, nothing runsv0.2.1version=0.2.1 skip=falsev1.0.0; touch /tmp/pwnedpnpm run buildproducessettings-vault-0.2.1.zip. The manifest inside reads"version": "0.2.1", andREADME.md,docs/vault-window.pnganddocs/updates-window.pngsit at the package root.Lint, typecheck and the 40 unit tests are green.
What happens when this merges
The workflow sees 0.2.1 with no tag, runs typecheck and the tests, builds, pushes
v0.2.1and opens the release with the zip and the manifest attached. Nothing to do by hand.