-
Notifications
You must be signed in to change notification settings - Fork 0
fix: make CPU/GPU Docker paths robust on Windows #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
665b8b2
fix: correct GPU pip install command
vtavakkoli 79a10ae
fix: align Docker static checks with working CPU/GPU images
vtavakkoli dcc705b
fix: enforce LF line endings for shell and Docker files
vtavakkoli bf44d59
fix: normalize GPU shell script line endings in image
vtavakkoli 65a345b
fix: keep named CPU/GPU images buildable by Compose
vtavakkoli 5f7f3bd
test: guard Windows CRLF and named image build config
vtavakkoli d293b64
chore: enforce LF for shell and Docker files
vtavakkoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Keep Linux shell scripts and container files on Unix line endings even when cloned on Windows. | ||
| *.sh text eol=lf | ||
| Dockerfile* text eol=lf | ||
| *.yml text eol=lf | ||
| *.yaml text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated check now explicitly accepts
pip install torch torchvisionwithout the CPU wheel index, even though the CPU Compose path is documented as using CPU-only PyTorch (README.md:67). On Linux, the default PyPI distribution can pull CUDA-enabled PyTorch and its NVIDIA dependencies, substantially bloating the CPU image while this workflow remains green. Keep asserting the/whl/cpuindex, and updateDockerfile.cpuaccordingly rather than weakening the validation.Useful? React with 👍 / 👎.