Skip to content

Allow deletion of HTTPRoute cert Object on FQDN change#681

Merged
github-actions[bot] merged 1 commit into
developfrom
fix/httproute-cert-fqdn-rename
May 20, 2026
Merged

Allow deletion of HTTPRoute cert Object on FQDN change#681
github-actions[bot] merged 1 commit into
developfrom
fix/httproute-cert-fqdn-rename

Conversation

@mdnix
Copy link
Copy Markdown
Member

@mdnix mdnix commented May 20, 2026

Summary

  • When changing FQDN in the claim, reconciliation got stuck because the cert Object name depends on the FQDN and the AppCat deletion-protection webhook blocked garbage collection of the old one.

Checklist

  • Update tests.
  • Link this PR to related issues.
  • Merge with /merge comment.

Component PR: vshn/component-appcat#1192

@mdnix mdnix requested a review from a team May 20, 2026 08:54
@mdnix mdnix self-assigned this May 20, 2026
@mdnix mdnix requested review from Kidswiss, TheBigLee, mikeshootzz and zugao and removed request for a team May 20, 2026 08:54
@mdnix mdnix added bug Something isn't working patch labels May 20, 2026
Copy link
Copy Markdown
Contributor

@mikeshootzz mikeshootzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayy, deletion protection strikes again :D

@github-actions
Copy link
Copy Markdown
Contributor

@mdnix
Copy link
Copy Markdown
Member Author

mdnix commented May 20, 2026

/merge

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot merged commit f2938c9 into develop May 20, 2026
9 checks passed
@github-actions github-actions Bot deleted the fix/httproute-cert-fqdn-rename branch May 20, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants