Color and Wemosd1 compression fixes, C# alignment, clangformat#45
Merged
Color and Wemosd1 compression fixes, C# alignment, clangformat#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @dekay and @superhac for doing thorough comparison's to DirectOutput.
Fixes: https://github.com/jsm174/libdof/issues/44
For reference, they compared to @nailbuster's video here.
As of now, we were seeing a few issues with the DOF Config Tool V3.0. I've notified via the contact form.
Setting:
17 FIREBRICK 500 L19 AT40 AW25 AH20 APS1600 APD100 APCGOLDTrigger is 17 maybe it should be S17?
Settings:
@flshemulo@ L0 / @flshemuli@ L1 / @flshemuc@ L2 / @flshemuri@ L3 / @flshemuro@ L4After substitution:
AH100 AL0 AT0 AW19 SHPCircle3 L0No trigger (like
E905) and no color (likeYellow) ?Settings:
@GoalReady@ Yellow M750 AL11 AW16 SHPLetterGI don't see
@GoalReady@variable anywhere.SHPCircle3Pulsefound in inis, but not inDirectOutputShapes.xml