Remove multi_json support#568
Conversation
Adding multi_json to a project for an unrelated reason would silently cause json-schema to use it instead of the json gem, introducing subtle behavioral differences. With modern Ruby and the json gem, multi_json is no longer needed.
|
@ekohl @bastelfreak is there anything further you'd like to see here, or is there anyone else to loop in? |
|
@bastelfreak asked whether this really is backwards incompatible or not. If it is, we should probably do a release with the current unreleased changes. |
|
That makes sense. It could change behavior in some edge cases when this is merged and mutli_json stops being used. If you think we should hold off for a major version change, we could merge #566 for now, which is backward compatible. I just now added a deprecation warning to that PR, in case you want to go that route. |
|
@bastelfreak any thoughts on this PR? And/or merging the other PR as an interim solution? |
|
Hi all — landing here from a real Rails 8 app where this PR is the only thing that silences a boot-time deprecation.
On the backwards-compat concern that paused this thread: That said, the maintainer agreement upthread (@ekohl, @bastelfreak) is clearly to remove (Mostly filing this to break the silence on the bastelfreak ping above; totally understand if waiting for a major version bump is the preferred path.) |
Adding multi_json to a project for an unrelated reason would silently cause json-schema to use it instead of the json gem, introducing subtle behavioral differences.
With modern Ruby and the json gem, multi_json is no longer needed.
See #565