Skip to content

fix(recall): ignore archived page titles#494

Open
Steve-too wants to merge 1 commit into
vouchdev:testfrom
Steve-too:fix/recall-ignore-archived-pages
Open

fix(recall): ignore archived page titles#494
Steve-too wants to merge 1 commit into
vouchdev:testfrom
Steve-too:fix/recall-ignore-archived-pages

Conversation

@Steve-too

@Steve-too Steve-too commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • exclude archived pages from the session-start recall digest
  • add a regression test covering archived page titles while keeping live pages visible

Closes #490

Tests

  • PYTHONPATH=src python3 -m pytest tests/test_recall.py
  • uv run --extra dev python -m pytest tests/test_recall.py
  • uv run --extra dev python -m ruff check src/vouch/recall.py tests/test_recall.py
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Archived pages are now excluded from generated recall digests.
    • Digest statistics now reflect only the pages included after filtering out archived content.
  • Tests
    • Added coverage to verify digests include live page content and exclude archived page content.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 974dd258-3604-4e67-a4fe-bd94e93e2b53

📥 Commits

Reviewing files that changed from the base of the PR and between 456742b and ba80581.

📒 Files selected for processing (2)
  • src/vouch/recall.py
  • tests/test_recall.py
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/vouch/recall.py
  • tests/test_recall.py

Walkthrough

build_digest now excludes archived pages from recall context while retaining visible active pages. A regression test verifies that archived page content is omitted and live page content remains included.

Changes

Recall digest filtering

Layer / File(s) Summary
Archived-page exclusion and regression coverage
src/vouch/recall.py, tests/test_recall.py
build_digest filters out PageStatus.ARCHIVED pages before applying visibility checks and updates hidden-page statistics; a regression test verifies the resulting digest contents.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: excluding archived page titles from recall digest generation.
Linked Issues check ✅ Passed The code filters archived pages from build_digest and adds regression coverage, matching the linked issue's scope.
Out of Scope Changes check ✅ Passed The changes are confined to recall filtering logic and a targeted regression test, with no unrelated edits evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added tests tests and fixtures size: XS less than 50 changed non-doc lines labels Jul 15, 2026
@plind-junior

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Steve-too
Steve-too force-pushed the fix/recall-ignore-archived-pages branch from 02219b0 to 456742b Compare July 24, 2026 19:19

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/vouch/recall.py`:
- Around line 84-87: Update the stats calculation in the page filtering flow
around all_pages, pages, and stats["hidden"] to use the count of non-archived
pages as the hidden-metric denominator rather than len(all_pages). Keep archived
pages excluded from both the visible results and the visibility-hidden count.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 24b03f9e-0a06-4133-a164-22c0d467455f

📥 Commits

Reviewing files that changed from the base of the PR and between 93c4724 and 456742b.

📒 Files selected for processing (2)
  • src/vouch/recall.py
  • tests/test_recall.py

Comment thread src/vouch/recall.py
@Steve-too
Steve-too force-pushed the fix/recall-ignore-archived-pages branch from 456742b to ba80581 Compare July 24, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS less than 50 changed non-doc lines tests tests and fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants