Skip to content

bug fix for ASDI with rotation thresold, small speed gain for frame_derotate, major update of test framework#705

Open
IainHammond wants to merge 7 commits intovortex-exoplanet:masterfrom
IainHammond:master
Open

bug fix for ASDI with rotation thresold, small speed gain for frame_derotate, major update of test framework#705
IainHammond wants to merge 7 commits intovortex-exoplanet:masterfrom
IainHammond:master

Conversation

@IainHammond
Copy link
Copy Markdown
Contributor

@IainHammond IainHammond commented Mar 27, 2026

I need to learn how to use branches.

First up is a bug fix for the case of ASDI in _adimsdi_doublepca. If we have source_xy but no reference cube  (i.e. IFS data with a planet but no cube_ref), an empty reference array is still provided to _project_subtract, causing a crash. This just fixes this case by adding a check for a reference cube.

Part two is me trying to get a small speed up to frame rotation. This was accomplished by removing an unnecessary double array operation when checking for NaNs, and also removing an extra array creation by just reshaping a current one. It's only a couple of seconds faster but it's something.

Finally, we were getting loads of warnings about the tests. Turns out they were a bit behind on updates (Node.js 20 deprecation). Checkout, setup-python, and pre-commit-hooks are all updated to the latest major release and that has fixed everything. The pre-commit is now its own job that runs first and just checks the code, instead of running 16 times (one for each of the 4 python versions, 3 times each, plus the 4 object tests) and will not start the tests unless it passes.

Enjoy !

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.27%. Comparing base (778923a) to head (f28620b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/vip_hci/psfsub/pca_fullfr.py 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #705       +/-   ##
===========================================
+ Coverage   32.51%   50.27%   +17.75%     
===========================================
  Files          88       88               
  Lines       17048    17049        +1     
===========================================
+ Hits         5543     8571     +3028     
+ Misses      11505     8478     -3027     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants