bug fix for ASDI with rotation thresold, small speed gain for frame_derotate, major update of test framework#705
Open
IainHammond wants to merge 7 commits intovortex-exoplanet:masterfrom
Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
===========================================
+ Coverage 32.51% 50.27% +17.75%
===========================================
Files 88 88
Lines 17048 17049 +1
===========================================
+ Hits 5543 8571 +3028
+ Misses 11505 8478 -3027 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to learn how to use branches.
First up is a bug fix for the case of ASDI in
_adimsdi_doublepca. If we have source_xy but no reference cube (i.e. IFS data with a planet but no cube_ref), an empty reference array is still provided to_project_subtract, causing a crash. This just fixes this case by adding a check for a reference cube.Part two is me trying to get a small speed up to frame rotation. This was accomplished by removing an unnecessary double array operation when checking for NaNs, and also removing an extra array creation by just reshaping a current one. It's only a couple of seconds faster but it's something.
Finally, we were getting loads of warnings about the tests. Turns out they were a bit behind on updates (Node.js 20 deprecation). Checkout, setup-python, and pre-commit-hooks are all updated to the latest major release and that has fixed everything. The pre-commit is now its own job that runs first and just checks the code, instead of running 16 times (one for each of the 4 python versions, 3 times each, plus the 4 object tests) and will not start the tests unless it passes.
Enjoy !