Repository navigation
feat(vortex): read DuckLake data files in the vortex format (per-file dispatch) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
c071203
feat(read): dispatch DuckLake data files by file_format (parquet + vo…
moshap-firebolt afb10ef
feat(format): generalize non-parquet reader + write/verify JSON & vor…
moshap-firebolt 4e9776f
feat(vortex): read DuckLake data files in the vortex format (per-file…
moshap-firebolt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ test/python/__pycache__/ | |
| .Rhistory | ||
| scripts/data/ | ||
| duckdb_benchmark_data/ | ||
| .cache/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule duckdb
updated
1100 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // DuckDB | ||
| // | ||
| // storage/ducklake_format_reader.hpp | ||
| // | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "duckdb/common/multi_file/base_file_reader.hpp" | ||
| #include "duckdb/function/table_function.hpp" | ||
| #include "duckdb/parallel/thread_context.hpp" | ||
|
|
||
| namespace duckdb { | ||
| struct DuckLakeFunctionInfo; | ||
|
|
||
| //! How an output column is produced. | ||
| enum class FormatReaderColumn : uint8_t { | ||
| FILE_COLUMN, //! read from the file (see output_source_index) | ||
| ORDINAL, //! file_row_number, emitted by the reader | ||
| MISSING //! not in the file -> NULL | ||
| }; | ||
|
|
||
| //! Reads a single non-parquet DuckLake data file ("vortex", "json", ...) by driving its read_<format> | ||
| //! table function and adapting the chunks to DuckLake's MultiFileReader contract (column mapping, | ||
| //! delete filters, pushed-down filters, file_row_number), like the parquet reader path does. | ||
| class DuckLakeFormatReader : public BaseFileReader { | ||
| public: | ||
| DuckLakeFormatReader(DuckLakeFunctionInfo &read_info, const OpenFileInfo &info, string format, | ||
| vector<MultiFileColumnDefinition> columns); | ||
|
|
||
| public: | ||
| bool TryInitializeScan(ClientContext &context, GlobalTableFunctionState &gstate, | ||
| LocalTableFunctionState &lstate) override; | ||
| AsyncResult Scan(ClientContext &context, GlobalTableFunctionState &global_state, | ||
| LocalTableFunctionState &local_state, DataChunk &chunk) override; | ||
| string GetReaderType() const override; | ||
| void AddVirtualColumn(column_t virtual_column_id) override; | ||
|
|
||
| private: | ||
| static TableFunction GetReadFunction(ClientContext &context, const string &format); | ||
|
|
||
| mutex lock; | ||
| DuckLakeFunctionInfo &read_info; | ||
| string format; //! selects the read_<format> function | ||
| bool initialized_scan = false; | ||
| int64_t file_row_number = 0; | ||
|
|
||
| //! read_<format> scan bound to the file | ||
| TableFunction file_scan; | ||
| unique_ptr<FunctionData> bind_data; | ||
| vector<LogicalType> file_types; | ||
| vector<string> file_names; | ||
|
|
||
| unique_ptr<ThreadContext> thread_context; | ||
| unique_ptr<ExecutionContext> execution_context; | ||
| unique_ptr<GlobalTableFunctionState> global_state; | ||
| unique_ptr<LocalTableFunctionState> local_state; | ||
|
|
||
| vector<column_t> scan_column_ids; //! columns projected out of the file | ||
| DataChunk scan_chunk; //! raw columns read from the file | ||
| vector<FormatReaderColumn> output_kinds; //! how each output column is produced | ||
| vector<idx_t> output_source_index; //! for FILE_COLUMN: position in scan_chunk | ||
| }; | ||
|
|
||
| } // namespace duckdb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.