Repository navigation
Fix LoRA fixture cleanup without Ray - #9
Closed
chinazhangchao wants to merge 1 commit into
Closed
chinazhangchao wants to merge 1 commit into
chinazhangchao wants to merge 1 commit into
Conversation
Only request Ray shutdown when it is initialized, so LoRA teardown also works in environments where Ray is not installed. Signed-off-by: Chao Zhang <zhangchao@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test cleanup logic in
tests/lora/conftest.pyto more robustly determine whether Ray should be shut down after tests. Instead of always attempting to shut down Ray, the code now checks if Ray is actually initialized before shutting it down, which helps avoid unnecessary shutdown calls and potential errors.Test infrastructure improvements:
cleanup_dist_env_and_memorycalls in both thecleanup_fixtureanddist_initfunctions to use the newis_ray_initialized()utility, ensuring Ray is only shut down if it has been started. [1] [2]is_ray_initializedfunction fromvllm.ray.lazy_utilsto support the new conditional shutdown logic.Build pipeline:
https://github.com/vortex-captain/ci-infra/actions/runs/44050289294
Test pipeline:
https://github.com/vortex-captain/ci-infra/actions/runs/44212174833/job/134500228031