Repository navigation
Enhance Windows support with native locking and conditional shutdown - #7
Closed
chinazhangchao wants to merge 2 commits into
Closed
chinazhangchao wants to merge 2 commits into
chinazhangchao wants to merge 2 commits into
Conversation
Port native locking, process ownership and graceful shutdown, sockets, and batch I/O to Windows. Qualify test helper imports for pytest importlib collection. Repair Windows commit-hook execution and typing, and wire FlashAttention interface unit tests into CPU CI. Keep unsupported POSIX capabilities explicit; native ARM64/GPU validation remains required. Signed-off-by: Chao Zhang <zhangchao@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements for Windows compatibility and cross-platform support, alongside updates to the test suite and documentation. The most significant changes include enhanced Windows support for file locking, network listeners, and process management, as well as updates to requirements and tests to ensure consistent behavior across platforms.
Windows Compatibility and Cross-Platform Support:
docs/cli/README.md,docs/features/initialized_snapshots.md,docs/features/speculative_decoding/extract_hidden_states.md, anddocs/serving/data_parallel_deployment.mdfiles. This includes details on file handle management, ZMQ listeners, HTTP socket backlogs, and process tree supervision using Windows Job Objects. (F1dccfb9L122R122, [1] [2] [3]portalocker[win32]>=4.4.2for proper file locking support.Test Suite Enhancements:
uvloop,winloop, orasyncio), platform-aware socket binding, and conditional imports. Added Windows-specific logic to ensure balanced accepts and listener setup intest_balanced_accepts.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]os._exit,process.kill(),signal.raise_signal) for improved cross-platform reliability. [1] [2] [3] [4]Build and Dependency Management:
vllm/vllm_flash_attnand related test files. [1] [2] [3] [4]Code Quality and Maintenance:
These changes collectively ensure that the codebase and tests behave consistently across platforms, particularly enhancing support for Windows environments.