Skip to content

Enhance Windows support with native locking and conditional shutdown - #7

Closed
chinazhangchao wants to merge 2 commits into
win_rebase/v0.33.0from
chao/fixtest
Closed

chinazhangchao wants to merge 2 commits into
win_rebase/v0.33.0from
chao/fixtest

Conversation

@chinazhangchao

Copy link
Copy Markdown
Collaborator

This pull request introduces comprehensive improvements for Windows compatibility and cross-platform support, alongside updates to the test suite and documentation. The most significant changes include enhanced Windows support for file locking, network listeners, and process management, as well as updates to requirements and tests to ensure consistent behavior across platforms.

Windows Compatibility and Cross-Platform Support:

  • Documented Windows-specific behaviors and limitations for batch processing, snapshot operations, speculative decoding, and data parallel deployment in the docs/cli/README.md, docs/features/initialized_snapshots.md, docs/features/speculative_decoding/extract_hidden_states.md, and docs/serving/data_parallel_deployment.md files. This includes details on file handle management, ZMQ listeners, HTTP socket backlogs, and process tree supervision using Windows Job Objects. (F1dccfb9L122R122, [1] [2] [3]
  • Updated the Windows requirements to use portalocker[win32]>=4.4.2 for proper file locking support.

Test Suite Enhancements:

  • Refactored test code to support both Unix and Windows platforms, including dynamic event loop selection (uvloop, winloop, or asyncio), platform-aware socket binding, and conditional imports. Added Windows-specific logic to ensure balanced accepts and listener setup in test_balanced_accepts.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Updated process management and signal handling in supervisor tests to use platform-appropriate methods (os._exit, process.kill(), signal.raise_signal) for improved cross-platform reliability. [1] [2] [3] [4]

Build and Dependency Management:

  • Added and refined source file dependencies in Buildkite test area configurations to include new modules and tests, such as vllm/vllm_flash_attn and related test files. [1] [2] [3] [4]
  • Modified the pre-commit configuration to enforce UTF-8 mode when validating configuration files.

Code Quality and Maintenance:

  • Improved test reliability and maintainability by using platform checks, cleaning up test fixtures, and ensuring consistent resource management in test code. [1] [2] [3] [4] [5]

These changes collectively ensure that the codebase and tests behave consistently across platforms, particularly enhancing support for Windows environments.

Port native locking, process ownership and graceful shutdown, sockets, and batch I/O to Windows. Qualify test helper imports for pytest importlib collection. Repair Windows commit-hook execution and typing, and wire FlashAttention interface unit tests into CPU CI. Keep unsupported POSIX capabilities explicit; native ARM64/GPU validation remains required.

Signed-off-by: Chao Zhang <zhangchao@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Signed-off-by:  <>
@chinazhangchao
chinazhangchao deleted the chao/fixtest branch November 18, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant