Repository navigation
Fix json-recursion error - #10
Draft
chinazhangchao wants to merge 1 commit into
Draft
chinazhangchao wants to merge 1 commit into
chinazhangchao wants to merge 1 commit into
Conversation
Signed-off-by: Chao Zhang <zhangchao@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: <>
Collaborator
Author
|
/ok to test debug-json-recursion ci=migrate-windows-github-actions |
Collaborator
|
In reply to this comment by @chinazhangchao:
Started on
|
Collaborator
|
Windows CI ( Pipeline 83529001
Test suite Logs (private repo, access needed): https://github.com/shivamkumard-ctrl/vllm-windows-ci-logs/tree/main/on-demand/run-83529001-debug-json-recursion-850d36f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the testing of structured output validation by addressing recursion limit issues encountered during test collection on certain platforms. The main change is replacing the use of
json.loadsfor deeply nested schemas with a direct dictionary construction to avoid exceeding platform-specific recursion limits.Test stability improvements:
_nested_array_schema_dictto build deeply nested JSON schema dictionaries directly, avoiding recursion limits during test collection.json.loads(_nested_array_schema(2_000))to_nested_array_schema_dict(2_000), ensuring compatibility with environments that have lower recursion limits.Code cleanup:
import jsonstatement fromtest_validation.py.