Skip to content

Skip TPM plugin install when tmux is unavailable in Debian Codespace builds#25

Merged
vorburger merged 1 commit into
mainfrom
copilot/fix-ci-build-failure
May 30, 2026
Merged

Skip TPM plugin install when tmux is unavailable in Debian Codespace builds#25
vorburger merged 1 commit into
mainfrom
copilot/fix-ci-build-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

Debian 12/13 Codespace CI builds were failing during bootstrap.sh because TPM plugin installation unconditionally invoked tmux in environments where tmux is intentionally not installed. This change makes TPM setup tolerant of tmux-less bootstrap contexts.

  • Root cause

    • all-install.sh cloned ~/.tmux/plugins/tpm and always ran ~/.tmux/plugins/tpm/bin/install_plugins, which fails when tmux is not on PATH.
  • Change

    • Added a command -v tmux guard before running TPM plugin installation.
    • Preserved TPM clone behavior; only plugin installation is skipped when tmux is absent.
  • Resulting behavior

    • Bootstrap continues successfully in CI/container setups without tmux.
    • On hosts with tmux installed, TPM plugins are still installed as before.
if [ ! -d ~/.tmux/plugins/tpm ]; then
  git clone https://github.com/tmux-plugins/tpm ~/.tmux/plugins/tpm
  if command -v tmux &> /dev/null; then
    ~/.tmux/plugins/tpm/bin/install_plugins
  else
    echo "Skipping tmux plugin installation because tmux is not installed."
  fi
fi

@vorburger vorburger marked this pull request as ready for review May 29, 2026 22:19
Copilot AI review requested due to automatic review settings May 29, 2026 22:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the shared install bootstrap tolerate Debian Codespace/container environments where tmux is intentionally absent, preventing TPM plugin installation from aborting the build.

Changes:

  • Adds a command -v tmux guard before running TPM’s install_plugins.
  • Emits a skip message when TPM is cloned but tmux is unavailable.
  • Preserves existing TPM clone behavior for later tmux-based setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vorburger vorburger merged commit 42bc044 into main May 30, 2026
8 checks passed
@vorburger vorburger deleted the copilot/fix-ci-build-failure branch May 30, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants