make methods of Request class overridable#24
Open
albertborsos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Request-t osztályt származtattam és felülírtam volna a request metódust. De mivel direktben hívja a
clientproperty-t (amiprivate) ezért nem lehet származtatni úgy hogy felülírhatóak legyenek a metódusok.Ezért le kellett duplikálnom az egész osztályt és felülírni a request metódust. Ami nem szerencsés, ha frissülne ez a package.
Erre megoldás ez a PR.
Amúgy a hibaüzeneteket a
requestmetódus nem adja vissza, hanem Exception-t dob. Ezt egy saját Request osztályban lekezeltem, hogy tömbként adja vissza a hibaüzeneteket, így rá lehet tenni egy űrlapra és nem kell leimplementálni a validációs szabályokat minden api model-re.Erre nem csinálok PR-t, mert nem lenne visszafele kompatibilis.