Draft
Conversation
MarleenEliza
commented
Jul 3, 2025
Comment on lines
+25
to
+29
| const Tags: { Tag: Tag; mark: string }[] = | ||
| node.marks?.map((mark) => { | ||
| const Tag = elementByMark[mark] || 'span'; | ||
| return { Tag: Tag, mark }; | ||
| }) || []; |
Member
Author
There was a problem hiding this comment.
loop over tags with marks
| const { node } = Astro.props; | ||
|
|
||
| const elementByMark: Record<DefaultMark, string> = { | ||
| type Tag = 'span' | 'strong' | 'em' | 'del' | 'mark' | 'code' | 'u'; |
Member
Author
There was a problem hiding this comment.
needs to be strongly typed in order to use Tag later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TODO
write migration to newer version of plugin after its been released.
Associated issue
How to test
Checklist