WIP: show somewhat dynamic rendering based on dynamic constraints#278
Closed
jurgenbelien wants to merge 5 commits intomainfrom
Closed
WIP: show somewhat dynamic rendering based on dynamic constraints#278jurgenbelien wants to merge 5 commits intomainfrom
jurgenbelien wants to merge 5 commits intomainfrom
Conversation
Deploying head-start with
|
| Latest commit: |
5543945
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb434742.head-start.pages.dev |
| Branch Preview URL: | https://feat-flex-prerender.head-start.pages.dev |
jbmoelker
reviewed
Jul 7, 2025
Member
There was a problem hiding this comment.
Since both catch all routes now just have a single file, we could change this to:
pages/[locale]/
[...serverPath].astro
[...staticPath].astro
jbmoelker
reviewed
Jul 7, 2025
|
|
||
| export const prerender = false; | ||
|
|
||
| export async function getStaticPaths() { |
Member
There was a problem hiding this comment.
Are these actually used in this server-rendered route? Or is this now the catch all route in production?
Member
|
Inactive. Closing. Added as reference for the related item on our roadmap document. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Head Start would benefit from more dynamic routing where:
In the current setup this is difficult to achieve because the
@pages/*.astrofiles handle many concerns:This PR introduces a new architecture pattern to allow mixing models and mixing pre-rendered and server-rendered pages by using:
src/views/that are only concerned with fetching record data and rendering a template with itsrc/pages/that are only concerned with route matching, fetching collection data to determine paths, defining if a page should be pre-rendered or not.Associated issue
N/A
How to test
Checklist