Repository navigation
fix(platform): use a replacement runtime token on install resume - #682
Merged
Merged
Conversation
After an install passed the setup-draft stage, `install --resume` kept the saved runtime token and ignored VOID_PLATFORM_RUNTIME_CLOUDFLARE_API_TOKEN. Workers the interrupted run had deployed also kept the old CF_API_TOKEN. - An explicit runtime token now wins over the saved one on every resume. A rejected saved token can be replaced at the prompt; cancelling keeps the saved token. - When the token differs from the saved one, it is sent to the deployed API and proxy Workers through the existing Worker secret update. A saved update left by a crash is finished on the next resume. - Only CF_API_TOKEN is sent. GitHub, R2 and email values keep their saved values and are not sent as updates. Fixes #666 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-install-resume-runtime-token-void-cloud.voidzero-docs.workers.dev (commit 609664f)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666
Problem
Fix (only
platform-lifecycle.ts)The installer, the secrets builder and the update mechanism are unchanged. The fix only feeds the token into them.
Answers to the issue's questions
workerSecretUpdatesintent. OnlyCF_API_TOKENis sent. With no saved token to compare (another machine), nothing is sent, as before.Tests
platform-setup-flow.test.tsplatform-install-cutover.test.tsOne existing test ("reuses the saved management token on resume") set the env runtime token and expected the saved one to win. It now leaves the runtime env var unset and keeps its check.
Docs: one paragraph in
docs/guide/platform/installation/setup.md.Verification
vp run test: 529 files, 11,927 tests passed.vp run --filter ./packages/void typecheck,vp lint,vp fmtclean.🤖 Generated with Claude Code