Skip to content

fix(staged)!: upgrade lint-staged and automate future updates - #2754

Merged
fengmk2 merged 1 commit into
mainfrom
fix/upgrade-lint-staged
Sep 20, 2026
Merged

fengmk2 merged 1 commit into
mainfrom
fix/upgrade-lint-staged

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 19, 2026

Copy link
Copy Markdown
Member

The bundled lint-staged@16.4.0 misses fixes for unstaged changes and Git state during pre-commit hooks. This change updates vp staged to use lint-staged@17.5.1.

BREAKING CHANGE: vp staged now requires Node.js 22.22.1 or later and Git 2.32.0 or later. Node.js 20.x is no longer supported for staged checks. The existing minimum of Node.js 24.11.0 still applies to the 24.x line. These requirements also apply to pre-commit hooks that run vp staged. Upgrade the project's Node.js runtime and Git on developer machines and CI runners. See the upstream breaking changes.

.github/workflows/upgrade-deps.yml calls an upgrade script that does not include lint-staged. The ^16.2.6 catalog range also prevents installation of 17.x. The script now updates the lint-staged catalog entry from the npm latest tag and includes the version in its upgrade report.

Fixes #2752.

@fengmk2
fengmk2 force-pushed the fix/upgrade-lint-staged branch from 7f84bc4 to 1c91869 Compare September 19, 2026 17:19
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 19, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-upgrade-lint-staged-viteplus-dev.voidzero-docs.workers.dev (commit afad353)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://b302bb7b-viteplus-dev.voidzero-docs.workers.dev afad353 2026-09-20T14:06:46.943Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://dbe8f4b7-viteplus-dev.voidzero-docs.workers.dev 3ab3c52 2026-09-20T09:17:54.901Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://23dc49a7-viteplus-dev.voidzero-docs.workers.dev 1c91869 2026-09-19T17:20:53.411Z Visit the dashboard ↗

@fengmk2 fengmk2 self-assigned this Sep 19, 2026
@fengmk2
fengmk2 marked this pull request as ready for review September 19, 2026 17:27
@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

CLI artifact sizes (afad353)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.15 MiB 2.00 MiB -151.36 KiB (-6.88%)
packages/core/dist Directory total 3.95 MiB 3.95 MiB 0 B (0.00%)
Combined package dist Directory total 6.10 MiB 5.95 MiB -151.36 KiB (-2.42%)
vp (Linux x64) Binary 11.23 MiB 11.23 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.86 MiB 4.86 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 32.03 MiB 32.03 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 12.70 MiB 12.70 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 8.38 MiB 8.38 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 4.24 MiB 4.24 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 39.66 MiB 39.66 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.01 MiB 17.01 MiB 0 B (0.00%)
vp (Windows x64) Binary 9.10 MiB 9.10 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 3.98 MiB 3.98 MiB 0 B (0.00%)
NAPI (Windows x64) Binary 26.99 MiB 26.99 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 10.80 MiB 10.80 MiB -6 B (-0.00%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.03 KiB 7.03 KiB 0 B (0.00%)
Installer (Windows x64) Binary 4.55 MiB 4.55 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.13 MiB 2.13 MiB -1 B (-0.00%)

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels Sep 20, 2026
@fengmk2
fengmk2 force-pushed the fix/upgrade-lint-staged branch from 1c91869 to 3ab3c52 Compare September 20, 2026 09:16
@fengmk2 fengmk2 changed the title fix(staged): upgrade lint-staged and automate future updates fix(staged)!: upgrade lint-staged and automate future updates Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: afad353

BREAKING CHANGE: vp staged now requires Node.js 22.22.1 or later and
Git 2.32.0 or later. Node.js 20 is no longer supported for staged checks.
The existing Node.js 24.11.0 minimum still applies to the 24.x line.
These requirements also apply to pre-commit hooks that run vp staged.
@fengmk2
fengmk2 force-pushed the fix/upgrade-lint-staged branch from 3ab3c52 to afad353 Compare September 20, 2026 14:05
@fengmk2
fengmk2 merged commit 4ce84fd into main Sep 20, 2026
119 checks passed
@fengmk2
fengmk2 deleted the fix/upgrade-lint-staged branch September 20, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump the bundled lint-staged in vp staged from 16.4.0 to 17.x (two data-loss fixes for hook users)

2 participants