feat: ship a Renovate preset and dependency-bot docs for lockstep updates - #2463
feat: ship a Renovate preset and dependency-bot docs for lockstep updates#2463fengmk2 wants to merge 2 commits into
Conversation
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
4b980d0 to
7cfd69a
Compare
3117523 to
fecc2bb
Compare
fecc2bb to
81a4412
Compare
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for viteplus-preview canceled.
|
…ates Every vp create / vp migrate project carries vite-plus plus the vite alias (npm:@voidzero-dev/vite-plus-core@<same version>), and vp test projects a pinned vitest override. Dependency bots update each package in its own PR, splitting the lockstep set. The root default.json is a shared Renovate preset, consumed as "extends": ["github>voidzero-dev/vite-plus"]. It groups vite-plus, @voidzero-dev/vite-plus-*, vitest, and @vitest/* into one PR and sets minimumReleaseAge and schedule on the group so no other rule can split member eligibility. The CI guide documents the preset and an equivalent Dependabot groups config, and the migration guide points at it from the overrides section. Refs #2356
The rule-level description restated the preset's top-level description; keep only the fact stated nowhere else (why minimumReleaseAge and schedule are pinned on the group). The CI guide now names all four commands the skew guard fails, not just build and test.
81a4412 to
2021490
Compare
| "groupName": "vite+", | ||
| "matchPackageNames": ["vite-plus", "@voidzero-dev/vite-plus-*", "vitest", "@vitest/*"], |
There was a problem hiding this comment.
We'd be happy having a "monorepo preset" for these packages in upstream Renovate, if that'd be helpful
| "description": "Explicit minimumReleaseAge and schedule give every member one eligibility policy, so another preset cannot hold one member back and split the group.", | ||
| "groupName": "vite+", | ||
| "matchPackageNames": ["vite-plus", "@voidzero-dev/vite-plus-*", "vitest", "@vitest/*"], | ||
| "minimumReleaseAge": "1 day", |
There was a problem hiding this comment.
IMO, users of this preset may be a bit surprised by this (especially if it differs to their existing settings)
There was a problem hiding this comment.
Yes, that's why I haven't continued with this PR either, because I do not want to modify the Renovate configuration.
I'm wondering if renovatebot/renovate#45630 this Renovate PR can solve the Vite+ version upgrade issue, then I can remove this preset. 💌
There was a problem hiding this comment.
Yes, that's the hope 🤞🏼
We do also have renovatebot/renovate#45631 for the Renovate config side, so y'all don't need to maintain that yourselves
Every
vp create/vp migrateproject carriesvite-plusplus thevitealias (npm:@voidzero-dev/vite-plus-core@<same version>), andvp testprojects a pinnedvitestoverride. Dependency bots update each package in its own PR, splitting the lockstep set. This is #2356 idea 1, stacked on the fail-fast guard (#2462).The root
default.jsonis a shared Renovate preset, consumed as"extends": ["github>voidzero-dev/vite-plus"]. It groupsvite-plus,@voidzero-dev/vite-plus-*,vitest, and@vitest/*into one PR, and setsminimumReleaseAgeandscheduleon the group so no other rule can split member eligibility (the failure mode from voidzero-dev/setup-vp#119; rule shape taken from the merged fixes voidzero-dev/setup-vp#121 and voidzero-dev/setup.viteplus.dev#42). The preset passesrenovate-config-validator.Docs: a new "Dependency Update Bots" section in the CI guide documents the preset and an equivalent Dependabot
groupsconfig, and the migration guide links to it from the overrides section.Refs #2356
Stack created with GitHub Stacks CLI • Give Feedback 💬