-
Notifications
You must be signed in to change notification settings - Fork 180
ci: publish preview packages to pkg.pr.new #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Boshen
wants to merge
4
commits into
main
Choose a base branch
from
ci/pkg-pr-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+390
−197
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1585bc6
ci: publish preview packages to pkg.pr.new
Boshen 61ee5ac
ci: move prep steps into publish-native-addons script
Boshen 94d6a4b
ci: order pkg.pr.new jobs by execution (prepare → build → publish)
Boshen 215caba
ci: harden release.yml against zizmor findings
Boshen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| name: Publish to pkg.pr.new | ||
|
|
||
| # https://pkg.pr.new/~/voidzero-dev/vite-plus | ||
|
|
||
| permissions: {} | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: [labeled] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| prepare: | ||
| if: >- | ||
| github.repository == 'voidzero-dev/vite-plus' && | ||
| (github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'pkg.pr.new'))) | ||
| name: Compute snapshot version | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| outputs: | ||
| version: ${{ steps.version.outputs.version }} | ||
| steps: | ||
| - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 | ||
|
|
||
| # pkg-pr-new rewrites the published version anyway, but we still need a | ||
| # unique snapshot version so `napi pre-publish` writes consistent | ||
| # optionalDependencies entries across the platform packages. | ||
| - name: Compute version | ||
| id: version | ||
| run: | | ||
| short_sha=$(git rev-parse --short=7 HEAD) | ||
| echo "version=0.0.0-pkg-pr-new.${short_sha}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| build-rust: | ||
| name: Build bindings and binaries | ||
| if: >- | ||
| github.repository == 'voidzero-dev/vite-plus' && | ||
| (github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'pkg.pr.new'))) | ||
| needs: prepare | ||
| permissions: | ||
| contents: read | ||
| uses: ./.github/workflows/reusable-release-build.yml | ||
| with: | ||
| version: ${{ needs.prepare.outputs.version }} | ||
| cache-key: pkg-pr-new | ||
|
|
||
| publish: | ||
| if: >- | ||
| github.repository == 'voidzero-dev/vite-plus' && | ||
| (github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'pkg.pr.new'))) | ||
| name: Pkg Preview | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - prepare | ||
| - build-rust | ||
| permissions: | ||
| # pkg-pr-new comments on PRs and posts run statuses with this token. | ||
| contents: read | ||
| pull-requests: write | ||
| env: | ||
| VERSION: ${{ needs.prepare.outputs.version }} | ||
| steps: | ||
| - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 | ||
| - uses: ./.github/actions/clone | ||
|
|
||
| - uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0 | ||
|
|
||
| - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version-file: .node-version | ||
| package-manager-cache: false | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Download cli dist | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: packages/cli/dist | ||
| pattern: cli | ||
| merge-multiple: true | ||
|
|
||
| - name: Download cli docs | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: packages/cli/docs | ||
| pattern: cli-docs | ||
| merge-multiple: true | ||
|
|
||
| - name: Download cli binding | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: packages/cli/artifacts | ||
| pattern: vite-plus-native-* | ||
|
|
||
| - name: Download core dist | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: packages/core/dist | ||
| pattern: core | ||
| merge-multiple: true | ||
|
|
||
| - uses: ./.github/actions/download-rolldown-binaries | ||
| with: | ||
| github-token: ${{ github.token }} | ||
| target: x86_64-unknown-linux-gnu | ||
| upload: 'false' | ||
|
|
||
| - name: Download Rust CLI binaries | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: rust-cli-artifacts | ||
| pattern: vite-global-cli-* | ||
|
|
||
| # Stops short of `npm publish` and leaves packages/cli/{npm,cli-npm}/* | ||
| # on disk for pkg-pr-new to upload. | ||
| - name: Prepare native addon and CLI binary packages | ||
| run: node ./packages/cli/publish-native-addons.ts --mode pkg-pr-new | ||
|
|
||
| - name: Publish to pkg.pr.new | ||
| run: | | ||
| pnpm dlx pkg-pr-new publish --compact --pnpm \ | ||
| './packages/cli/npm/*' \ | ||
| './packages/cli/cli-npm/*' \ | ||
| './packages/cli' \ | ||
| './packages/core' \ | ||
| './packages/test' | ||
Check noticeCode scanning / zizmor prefer trusted publishing for authentication Note
prefer trusted publishing for authentication
|
||
|
Comment on lines
+131
to
+136
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
.github/workflows/publish-to-pkg.pr.new.yml, the workflow listens topull_requesttypes: [labeled]but the job condition checkscontains(github.event.pull_request.labels.*.name, 'pkg.pr.new'); this becomes true for any later label event oncepkg.pr.newis already present, so adding unrelated labels will re-run the full build/publish flow and create duplicate preview publishes/comments. Restrict the pull-request branch of this condition to the actual event label (for examplegithub.event.label.name == 'pkg.pr.new') to avoid unintended reruns.Useful? React with 👍 / 👎.