fix: Fish env setup using string literal command when using vp env commands

[mikkurogue]

I noticed this was an issue with my setup, I'm not sure if it's a problem elsewhere but I noticed that when I ran vp env use 25 it would fail with "command": no such file or directory". Traced it to the env.fish module and changed it to __VP_BIN__ and resourced my config and it was working again.

Thought I'll provide a PR but feel free to flame and tell me I'm totally wrong.

[netlify]

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	47069bf
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69fc6e36146fb400084ada1f
😎 Deploy Preview	https://deploy-preview-1518--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[nekomoyi]

@mikkurogue Thanks for the PR! The change looks reasonable, but I'd like to understand the root cause better before merging.

The vp function is defined inside env.fish, which already prepends __VP_BIN__ to PATH before the function exists. So by the time command vp runs, it should resolve correctly via PATH lookup.

I can't reproduce locally with fish. Could you share more details on how this error occurs — specific fish version, install method, or a repro path?

Also, test cases that assert command usage would need to be updated.

[mikkurogue]

I'll try my best to explain what I did @nekomoyi

I upgraded vite plus with vp upgrade from 0.1.18 to latest (0.1.20 at time of writing) and noticed when I wanted to change my system node version to use node 26 to play around with the temporal api on a work project that vp env use 26 would result in the failure. Using vp env install 26 did however work just fine. After snooping around my vite-plus install for the env.fish, I saw the command part and found it odd that the error was "command": no such file or directory and that I concluded then it maybe is one of 2 things:

• Skill issue from me not re-sourcing fish config when upgrading vite plus
• command is being seen as a string literal to look for a file or directory and tries to execute this instead

In my dotfiles repo I have my fish config which sources the vp env here. I don't think it's wrong but I am not one known to maintain my own configs very well.

Currently on my work laptop so I can't source the full fish but I know it is version 4.6.0. As I have not yet done a system upgrade on my own machine this week.

My system is;
Cachyos kernel 7.0.0-2
Niri latest
Ghostty + Fish

I'm not really too sure how to reproduce this, but I do know if I revert the local changes to the vp env.fish to use command again that it will break again. Note; I havent run vp env setup since installing vite plus on the initial release so I wont rule it out that I'm kind of stupid. I am fully open to the idea that it's just a me issue, and not a vite plus issue.

I'll update the tests later today/tonight (+- 8pm EEST) to at least clean it up. I'll try to provide more information today as the day goes and I'm finished with my day job.
Updated tests to reflect it.

[nekomoyi]

@mikkurogue I may have found the cause. Could you help me test a change?

set -l __vp_out (env FISH_VERSION=$FISH_VERSION command vp $argv); or return $status

Because it runs through env, command is no longer interpreted as the fish builtin. Instead, env tries to execute an external binary named command.

That explains why I couldn’t reproduce it locally: on my machine, command resolves to /usr/bin/command, but CachyOS may not work as such.

Could you try changing only this line to __VP_BIN__/vp? If this works on your machine, we can keep the rest of the command vp usage unchanged.

[mikkurogue]

Yep, I'll test it later for you when I am at my personal machine. Will update once checked

[mikkurogue]

Updating fish.env to use
set -l __vp_out (env FISH_VERSION=$FISH_VERSION command vp $argv); or return $status results in the same error:

mikku@cachyos  ><> ~/.vite-plus
> vp env use 25
env: ‘command’: No such file or directory

setting it to set -l __vp_out (env FISH_VERSION=$FISH_VERSION $HOME/.vite-plus/bin/vp $argv); or return $status works as intended, and generating it with __VP_BIN__/vp seems to do the trick.

So I would assume only changing the one instance to __VP_BIN__/vp is sufficient instead of all instances. I'll push the commit as well, to see if we're on the same page 😄

[nekomoyi]

@mikkurogue That aligns perfectly with what I was expecting. Thanks for the fix！

[mikkurogue]

Can also confirm that on MacOS using fish, the issue does not occur. It must be either a Linux or Cachy problem. I would test on other distros but I don't have the time to find a disk and install all major distros for this and setup fish.

[fengmk2]

@mikkurogue @nekomoyi Thanks!

[fengmk2]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a44d2fbca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[fengmk2]

create-framework-shim-astro snap test is unstable, I need to fix it first