Skip to content

chore(ci): rewrite upgrade deps script in typescript#1514

Merged
fengmk2 merged 3 commits intomainfrom
c/05-05-chore_ci_rewrite_upgrade_deps_script_in_typescript
May 6, 2026
Merged

chore(ci): rewrite upgrade deps script in typescript#1514
fengmk2 merged 3 commits intomainfrom
c/05-05-chore_ci_rewrite_upgrade_deps_script_in_typescript

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented May 5, 2026

since node can nativly run typescript, lets write the script in typescript, and get all the typechecking benifits that come alongside that.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 6d4f1a0
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69faaaf44650ec00083a298b
😎 Deploy Preview https://deploy-preview-1514--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@camc314 camc314 marked this pull request as ready for review May 5, 2026 09:50
Copilot AI review requested due to automatic review settings May 5, 2026 09:50
Copy link
Copy Markdown
Contributor Author

camc314 commented May 5, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the automated “upgrade upstream dependencies” GitHub Actions workflow to use a TypeScript rewrite of the upgrade script, improving type-safety and runtime validation while keeping the script’s responsibilities (bumping upstream hashes and key tool versions, and writing metadata for PR generation) the same.

Changes:

  • Switch the workflow to run the upgraded dependency script from .mjs to .ts.
  • Rewrite the upgrade script with TypeScript types, stronger response-shape checks, and shared JSON-reading utilities.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/upgrade-deps.yml Updates the workflow step (and embedded docs) to call the .ts upgrade script.
.github/scripts/upgrade-deps.ts TypeScript refactor: adds explicit types, tighter API response validation, and small safety checks when editing JSON/YAML files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/upgrade-deps.yml
@camc314 camc314 force-pushed the c/05-05-chore_ci_rewrite_upgrade_deps_script_in_typescript branch from cbb4e85 to a39b5fd Compare May 5, 2026 10:01
@camc314 camc314 force-pushed the c/05-05-chore_ci_rewrite_upgrade_deps_script_in_typescript branch from a39b5fd to edd1dd6 Compare May 5, 2026 10:10
@fengmk2 fengmk2 merged commit 0901785 into main May 6, 2026
41 checks passed
@fengmk2 fengmk2 deleted the c/05-05-chore_ci_rewrite_upgrade_deps_script_in_typescript branch May 6, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants