test(snap): add pnpm v11 snap tests for command adaptation coverage#1289
Merged
graphite-app[bot] merged 1 commit intomainfrom May 6, 2026
Merged
test(snap): add pnpm v11 snap tests for command adaptation coverage#1289graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
pnpm-v11-snap-tests
branch
from
155a35d to
733d977
Compare
Member
Author
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c4e9579. Configure here.
fengmk2
force-pushed
the
pnpm-v11-snap-tests
branch
from
c0f9791 to
c130058
Compare
cpojer
approved these changes
May 6, 2026
fengmk2
force-pushed
the
pnpm-v11-snap-tests
branch
from
8dd7d2c to
d4c90b7
Compare
Merge activity
|
…1289) Add 26 snap test cases for `pnpm@11.0.6` (latest stable v11), mirroring the existing pnpm10 test suite, to validate `vp`'s command-adaptation layer against pnpm v11. ## Coverage New `snap-tests-global/*-pnpm11` fixtures for: add, cache, config, dedupe, dlx, link, list, outdated, owner, pack, prune, publish, remove, unlink, update, view, vpx, why, dev-engines-runtime — plus workspace variants for add/list/outdated/pack/remove/update/why. ## pnpm v11 compatibility findings - **`cache`,** **`dlx`,** **`owner`,** **`view`,** **`vpx`** — output identical to pnpm v10. - **`add`,** **`install`,** **`link`** — now report `packageManagerDependencies` (`@pnpm/exe`, `pnpm`) as part of install output; captured in snapshots. - **`why`** — output format restructured from tree-based to flat; captured in snapshots. - **`publish --dry-run`** — pnpm v11 no longer delegates to npm; minor output diff captured. - **`unlink`** **(workaround applied)** — pnpm v11 now runs a reconciling install after removing the override from `pnpm-workspace.yaml`. Under `CI=true` this defaults to `--frozen-lockfile` and fails with `ERR_PNPM_LOCKFILE_CONFIG_MISMATCH`. Fix: snap tests pass `-- --no-frozen-lockfile` to `vp unlink`. - **`config`** **at project scope (workaround applied)** — pnpm v11 moved project config from `.npmrc` into `pnpm-workspace.yaml`, which only accepts camelCase keys. Test key renamed to `vitePlusPmConfigTestKey`. - **`dev-engines-runtime`** — bumped pinned Node.js to `22.22.2` to satisfy vp's current minimum (`^20.19.0 || >=22.12.0`). - **`prune`** — skipped on `win32` (platform-specific output instability, matches other tests). Global install is not affected — `vp install -g` already forces npm. ## RFC updates pnpm v11 is now stable, so the support matrix in 7 RFCs (`add-remove`, `dedupe`, `install`, `link-unlink`, `outdated`, `update`, `why`) lists `pnpm@11.x` as supported (no WIP marker). The `link-unlink` entry retains the `-- --no-frozen-lockfile` note for CI usage. ## Test plan - [x] `pnpm -F vite-plus snap-test-global pnpm11` — all 26 cases pass with clean exit codes - [x] `cargo test -p vite_install --lib commands::unlink` — unit tests still pass - [x] CI green on all platforms
graphite-app
Bot
force-pushed
the
pnpm-v11-snap-tests
branch
from
d4c90b7 to
899bf25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 26 snap test cases for
pnpm@11.0.6(latest stable v11), mirroring the existing pnpm10 test suite, to validatevp's command-adaptation layer against pnpm v11.Coverage
New
snap-tests-global/*-pnpm11fixtures for: add, cache, config, dedupe, dlx, link, list, outdated, owner, pack, prune, publish, remove, unlink, update, view, vpx, why, dev-engines-runtime — plus workspace variants for add/list/outdated/pack/remove/update/why.pnpm v11 compatibility findings
cache,dlx,owner,view,vpx— output identical to pnpm v10.add,install,link— now reportpackageManagerDependencies(@pnpm/exe,pnpm) as part of install output; captured in snapshots.why— output format restructured from tree-based to flat; captured in snapshots.publish --dry-run— pnpm v11 no longer delegates to npm; minor output diff captured.unlink(workaround applied) — pnpm v11 now runs a reconciling install after removing the override frompnpm-workspace.yaml. UnderCI=truethis defaults to--frozen-lockfileand fails withERR_PNPM_LOCKFILE_CONFIG_MISMATCH. Fix: snap tests pass-- --no-frozen-lockfiletovp unlink.configat project scope (workaround applied) — pnpm v11 moved project config from.npmrcintopnpm-workspace.yaml, which only accepts camelCase keys. Test key renamed tovitePlusPmConfigTestKey.dev-engines-runtime— bumped pinned Node.js to22.22.2to satisfy vp's current minimum (^20.19.0 || >=22.12.0).prune— skipped onwin32(platform-specific output instability, matches other tests).Global install is not affected —
vp install -galready forces npm.RFC updates
pnpm v11 is now stable, so the support matrix in 7 RFCs (
add-remove,dedupe,install,link-unlink,outdated,update,why) listspnpm@11.xas supported (no WIP marker). Thelink-unlinkentry retains the-- --no-frozen-lockfilenote for CI usage.Test plan
pnpm -F vite-plus snap-test-global pnpm11— all 26 cases pass with clean exit codescargo test -p vite_install --lib commands::unlink— unit tests still pass