fix: i18n property bindings should use Bindings marker, not I18n marker in consts#6
Merged
Merged
Conversation
…er in consts Angular's compiler never produces I18n AttributeMarker (6) in consts arrays. The previous override in attribute_extraction converted i18n property bindings to BindingKind::I18n, creating duplicate consts entries that shifted all subsequent const indices. This fixes 8 mismatched files (~396 numeric diffs). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Brooooooklyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular's compiler never produces I18n AttributeMarker (6) in consts arrays. The previous override in attribute_extraction converted i18n property bindings to BindingKind::I18n, creating duplicate consts entries that shifted all subsequent const indices. This fixes 8 mismatched files (~396 numeric diffs).
Note
Medium Risk
Changes how i18n-annotated property/interpolated bindings are represented in the emitted consts array, which can affect directive matching and const index stability across templates. Scope is narrow and backed by targeted integration tests, but it alters generated output.
Overview
Stops overriding
UpdateOp::Propertybindings toBindingKind::I18nduring attribute extraction, and instead emits the property op’s existingbinding_kindso i18n annotations don’t create extra/shifted consts entries.Updates integration coverage to assert i18n-marked property and interpolated attributes produce the Bindings marker (
3) and explicitly do not emit the I18n marker (6) in consts arrays.Written by Cursor Bugbot for commit abfa8eb. This will update automatically on new commits. Configure here.