fix(angular): fix 3 compiler divergences from Angular reference#30
Merged
Conversation
Brooooooklyn
changed the title
Brooooooklyn
added a commit
that referenced
this pull request
Feb 23, 2026
1. Standalone @case/@default blocks now produce "Unrecognized block" error and UnknownBlock node instead of being silently dropped. 2. @case blocks with extra parameters now report error but still parse using the first parameter, matching Angular's error recovery behavior. 3. Unexpected i18n metadata types on conditional blocks now panic with a descriptive message instead of being silently ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/angular-case-default-divergences
branch
from
494f3bd to
a71e928
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
1. Standalone @case/@default blocks now produce "Unrecognized block" error and UnknownBlock node instead of being silently dropped. 2. @case blocks with extra parameters now report error but still parse using the first parameter, matching Angular's error recovery behavior. 3. Unexpected i18n metadata types on conditional blocks now panic with a descriptive message instead of being silently ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/angular-case-default-divergences
branch
from
a71e928 to
f36065c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and UnknownBlock node instead of being silently dropped.
using the first parameter, matching Angular's error recovery behavior.
descriptive message instead of being silently ignored.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Changes compiler ingestion/transform behavior for control-flow blocks and i18n metadata; risk is mainly around altered error recovery and diagnostics potentially affecting generated IR for edge-case templates.
Overview
Aligns Angular control-flow parsing with upstream error recovery: standalone
@case/@defaultnow emit an "Unrecognized block" diagnostic and produce anUnknownBlocknode instead of being dropped, and@casewith extra parameters now reports an error but still parses using the first parameter.Improves i18n robustness in
ingest.rsby validating conditional-block i18n metadata types and emitting a diagnostic when unexpected types are encountered (rather than silently ignoring). Adds/updates tests to cover the new@switchand standalone block behaviors, plus several small refactors/borrow/move cleanups inhtml_to_r3.rs.Written by Cursor Bugbot for commit f36065c. This will update automatically on new commits. Configure here.