fix(angular): fix 5 compiler divergences from Angular reference#28
Merged
Conversation
ad19b39 to
655700f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
1. Standalone connected blocks (@else, @empty, @Placeholder, @Loading, @error) now emit error diagnostics and produce UnknownBlock nodes instead of being silently dropped. 2. @defer connected block validation now rejects duplicate @placeholder/ @loading/@error, @error with parameters, and unrecognized params in @placeholder/@Loading blocks. 3. @switch case groups now propagate i18n metadata via create_block_placeholder() instead of hardcoding None. 4. parse_track_expression now returns empty string for bare "track " so the downstream EmptyExpr check produces the correct diagnostic. 5. Comments between connected blocks are no longer marked as processed, matching Angular's findConnectedBlocks behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
655700f to
b4f2914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Standalone connected blocks (@else, @empty, @Placeholder, @Loading,
@error) now emit error diagnostics and produce UnknownBlock nodes
instead of being silently dropped.
@defer connected block validation now rejects duplicate @placeholder/
@loading/@error, @error with parameters, and unrecognized params in
@placeholder/@Loading blocks.
@switch case groups now propagate i18n metadata via
create_block_placeholder() instead of hardcoding None.
parse_track_expression now returns empty string for bare "track "
so the downstream EmptyExpr check produces the correct diagnostic.
Comments between connected blocks are no longer marked as processed,
matching Angular's findConnectedBlocks behavior.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Changes parsing/validation behavior and emitted AST nodes for control-flow blocks, which may affect downstream consumers and error expectations despite being well-covered by new tests.
Overview
Fixes several Angular compiler divergences in the template-to-R3 transform.
Standalone connected blocks (
@else,@empty,@placeholder,@loading,@error) now emit diagnostics and produceUnknownBlocknodes instead of being silently ignored, and comment nodes between connected blocks are skipped without being marked processed.Tightens
@deferconnected-block handling to validate duplicates and parameters (rejects multiple connected blocks of the same type, forbids params on@error, and reports unrecognized params on@placeholder/@loading), propagates i18n metadata for@switchcase groups, and adjusts@fortrackparsing to treattrackas a match so the downstream empty-expression diagnostic is triggered (removing unused deferred-time param helpers accordingly).Written by Cursor Bugbot for commit b4f2914. This will update automatically on new commits. Configure here.