SPIRV-LLVM-Translator{19,21,22}: fix update file#61153
Merged
Merged
Conversation
| @@ -1 +1 @@ | |||
| pattern="/v\K19\.[0-9.]+(?=\.tar\.gz)" | |||
| pattern="refs/tags/v\K19\.[0-9.]+" | |||
Member
There was a problem hiding this comment.
Suggested change
| pattern="refs/tags/v\K19\.[0-9.]+" | |
| pattern="refs/tags/v\K19\.[0-9.]+($|(?=^))" |
and same for the others
Contributor
Author
There was a problem hiding this comment.
Applied to all update files in this PR.
Rutpiv
force-pushed
the
SPIRV-LLVM-Translator
branch
from
3e06f3f to
eb9d93b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
SPIRV-LLVM-Translator{19,21,22}had theirupdatefiles broken by #60025(info/refs migration); this migrates all three to the
refs/tagspattern soupdate-checkreports them again.No version bump here, on purpose: recent releases pull in the
SPV_INTEL_predicated_ioextension, whose opcodes only exist in SPIRV-Headersmaster, not in any released tag (including1.4.350.1from #61152). Buildingagainst them fails until a SPIRV-Headers release ships those symbols, so the
templates stay pinned for now.
update-checkwill start flagging these once tracking is back. They should beheld, not bumped, until SPIRV-Headers catches up.