refactor: simplify variable annotation lookup (VF-3664)#294
Draft
trs wants to merge 3 commits intodaniel/json-access/VF-3664from
Draft
refactor: simplify variable annotation lookup (VF-3664)#294trs wants to merge 3 commits intodaniel/json-access/VF-3664from
trs wants to merge 3 commits intodaniel/json-access/VF-3664from
Conversation
Contributor
Author
|
Checking with product to see if we want to support the recursive resolution, and to what extent. |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes or implements VF-3664
Brief description. What is this change?
Utilize the matching groups and of regex and the lodash
getmethod to simplify the variable annotation lookup.We recursively replace the string to allow for deep lookups such as
{array[{index}]}for more dynamic lookups.Tests have been updated to follow the AAA pattern.