Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

[Placeholder] Plugin/tanzu auth/support pinniped supervisor scopes#4482

Closed
joshuatcasey wants to merge 13 commits into
mainfrom
plugin/tanzu-auth/support-pinniped-supervisor-scopes
Closed

[Placeholder] Plugin/tanzu auth/support pinniped supervisor scopes#4482
joshuatcasey wants to merge 13 commits into
mainfrom
plugin/tanzu-auth/support-pinniped-supervisor-scopes

Conversation

@joshuatcasey
Copy link
Copy Markdown
Member

@joshuatcasey joshuatcasey commented Mar 15, 2023

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 15, 2023

Hi @joshuatcasey! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 15, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230315185804/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@benjaminapetersen benjaminapetersen force-pushed the plugin/tanzu-auth/support-pinniped-supervisor-scopes branch from ee8628f to 670a9bc Compare March 16, 2023 17:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 16, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230316172608/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@benjaminapetersen benjaminapetersen force-pushed the plugin/tanzu-auth/support-pinniped-supervisor-scopes branch from 670a9bc to de1777d Compare March 17, 2023 19:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230317191404/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230317205148/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@benjaminapetersen
tanzu-auth plugin: support conditional scopes for pinniped supervisor…
b5013fd 
… 0.12.1- or 0.22.0+
@benjaminapetersen
HACKERY AND COMMENTS AND SOME CODE
8fa4550
@benjaminapetersen
comments while working out the various plugins and core commands to u…
3ded222 
…pdate
@benjaminapetersen
Duplicate GetPinnipedSupervisorDiscovery() for core commands, specifi…
5104447 
…cally 'tanzu context'
@benjaminapetersen
Update 'tanzu context' command to check in with pinniped supervisor f…
94c290f 
…or scopes
@benjaminapetersen
comment cmd/cli/plugin/login
520ef26
@benjaminapetersen
Remove unused copy of KubeconfigWithPinnipedAuthLoginPlugin() from tk…
ee706fb 
…g/auth
@benjaminapetersen
Remove test references to unused KubeconfigWithPinnipedAuthLoginPlugi…
7e437d8 
…n() func in tkg/auth
@benjaminapetersen
Remove stub code path I began previously (misdirection)
228fbd9
@benjaminapetersen
Add cli/core/pkg/auth/tkg/types.go as separate file as these types ma…
42f583a 
…y need to exist elsewhere
@benjaminapetersen
Logging, etc.
211363c
@benjaminapetersen
tweaks
05e6369
@benjaminapetersen benjaminapetersen force-pushed the plugin/tanzu-auth/support-pinniped-supervisor-scopes branch from 9ca21b8 to 05e6369 Compare March 20, 2023 14:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230320143237/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4482/20230320194525/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@benjaminapetersen benjaminapetersen added do-not-merge/wip Still work in progress area/security area/iam Related to identity access management do-not-merge/hold Some fixes necessary, hold for merging labels Apr 4, 2023
@benjaminapetersen
Copy link
Copy Markdown
Contributor

benjaminapetersen commented Apr 4, 2023

This PR is going to be revised heavily based on #4533 as we want to get our code in one place before we add new functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area/iam Related to identity access management area/security cla-not-required do-not-merge/hold Some fixes necessary, hold for merging do-not-merge/wip Still work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuatcasey @benjaminapetersen @vmwclabot