Update SMDBoxHandler for new smdbox v2 - #23
Merged
Merged
Conversation
- Serve the canonical embed page with absolute URLs from vmkteam.github.io/smdbox (GitHub Pages, v2 bundle) instead of the frozen jsDelivr legacy dist - Drop external Bootstrap CSS since the v2 bundle is self-contained - Update README ecosystem link from semrush/smdbox to vmkteam/smdbox - Fix staticcheck QF1012 in parser: use fmt.Fprintf instead of sb.WriteString(fmt.Sprintf(...)) - Exclude goconst for middleware.go in golangci-lint config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SMDBoxHandlernow serves the canonical embed page from the new vmkteam/smdbox v2 with absolute URLs to the GitHub Pages bundle (https://vmkteam.github.io/smdbox/app.{js,css}). The jsDelivr@latest/dist/bundle is frozen as legacy in smdbox v2 and no longer updated.viewportmeta added for the responsive UI.#json-rpc-rootauto-init is kept — smdbox v2 preserves this backward-compatible contract.make lintgreen:fmt.Fprintfinstead ofsb.WriteString(fmt.Sprintf(...))in parser (staticcheck QF1012), goconst exclusion formiddleware.goin.golangci.yml.Testing
make fmt lint— 0 issues,go test ./...— ok.testdata/arithsrv:/docserves the page, the v2 widget auto-initializes into#json-rpc-root, pre-fills the schema URL, loads the SMD schema and lists all namespaces (arith, phonebook, printer).Release v2.3.3 (patch) should be tagged after merge; generator version is untouched.