Skip to content

Fix memory leaks in GameEventMgr, MotionMaster, ObjectMgr and Pet#3220

Open
schell244 wants to merge 2 commits intovmangos:developmentfrom
schell244:fix_memory_leaks
Open

Fix memory leaks in GameEventMgr, MotionMaster, ObjectMgr and Pet#3220
schell244 wants to merge 2 commits intovmangos:developmentfrom
schell244:fix_memory_leaks

Conversation

@schell244
Copy link
Contributor

🍰 Pullrequest

Fix some memory leaks and uninitialized member variables discovered during Valgrind profiling.

  • GameEventMgr: Implement destructor to clean up mGameEventHardcodedList entries
  • MotionMaster: Fix memory leak in ClearType() by deleting non-static movement generators
  • ObjectMgr: Add cleanup methods for item prototypes and creature auras
  • Pet: Add ClearCharmInfo() call in destructor
  • MasterPlayer: Initialize unReadMails and m_nextMailDelivereTime in constructor
  • battleground_alterac: Initialize Event_Timer and Point in Reset()
  • MotionMaster: Remove stray semicolon
  • PlayerBotAI: Add cleanup on error path and PvP flag initialization

Proof

  • None

Issues

  • None

How2Test

  • None

Todo / Checklist

  • None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant