Conversation
- Add --skill-id flag for server-side skill references as <name>:<version> - --skill and --skill-id are mutually exclusive - Replace --json/-j with --format/-f json for output format selection - Update help text and examples - Update tests to match new CLI options Co-Authored-By: Sudeep Pillai <sudeep.pillai@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CLI changes to the
vlmrun chatcommand:--skill-id: New repeatable option for referencing server-side skills as<skill-name>:<version>(e.g.my-skill:latest,my-skill:3). If no version is provided, defaults tolatest. Mutually exclusive with--skill(inline skill directories).--format jsonreplaces--json/-j: Output format is now specified via--format/-fwithjsonas the only currently supported value. This is a breaking change — the old--jsonflag is removed with no backward-compatible alias.Help text and examples updated to document both changes.
Review & Testing Checklist for Human
--json/-jis fully removed. Any existing scripts, CI pipelines, or docs referencingvlmrun chat --jsonwill break. Verify this is intentional and no deprecation period is needed.--skill-idparsing logic: The<name>:<version>splitting (rsplit(":", 1)) and the fallback toversion="latest"when no colon is present have no dedicated unit tests. Consider whether edge cases (empty name, empty version likeskill:, multiple colons) need coverage.--skilland--skill-idshould error, but this path is untested.vlmrun chat "hello" --skill-id my-skill:latestandvlmrun chat "hello" --format json --no-streamto verify both features work end-to-end against the API.Notes
--formatoption is a string rather than an enum, so it's extensible for future formats (e.g.yaml,csv) but currently only acceptsjson(case-insensitive).AgentSkill(type="skill_reference", skill_id=<name>, version=<version>)and serialized into theextra_body.skillspayload, same path as inline skills.Link to Devin session: https://app.devin.ai/sessions/d40920dcf04246b7af4636b4fa6f5a65
Requested by: @spillai