fix: convert str file path to Path before calling .stat() in _handle_file_or_url#165
Merged
dineshreddy91 merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
…file_or_url Co-Authored-By: dylan <dylan@carysoftwaresolutions.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
AttributeError: 'str' object has no attribute 'stat'when passing a string file path toclient.document.generate(file="some_file.pdf").The
_handle_file_or_urlmethod acceptsUnion[Path, str]for thefileparameter, but the branch that handles file paths with extensions calledfile.stat()without first converting the string to aPathobject. Addedfile = Path(file)before the.stat()call — this is safe for bothstrandPathinputs sincePath(Path(...))is a no-op.Review & Testing Checklist for Human
client.document.generate(file="some_file.pdf", ...)with a string path — should no longer raiseAttributeErrorPathobject still works as beforeNotes
Path(file)conversion was already done two lines below when callingself._client.files.upload(file=Path(file), ...), so this makes the code consistent.ImagePredictions._handle_images_or_urlsis not affected — it uses a different pattern withstr(image).Link to Devin session: https://app.devin.ai/sessions/691f8a989ec340a397e56a2e178b91d7
Requested by: @DylanSoftware