Skip to content

[Enhancement] Strengthen pre-commit hooks and replace CPU-only CI - #271

Merged
jiangkuaixue123 merged 1 commit into
vllm-project:mainfrom
yenuo26:pre-commit
Aug 26, 2026
Merged

[Enhancement] Strengthen pre-commit hooks and replace CPU-only CI#271
jiangkuaixue123 merged 1 commit into
vllm-project:mainfrom
yenuo26:pre-commit

Conversation

@yenuo26

@yenuo26 yenuo26 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace .github/workflows/cpu-only-ci.yml with a pre-commit workflow that checks only files changed in the PR/push, and installs shellcheck in CI.
  • Expand .pre-commit-config.yaml with ruff/typos/actionlint/markdownlint, plus local hooks for mypy, SPDX headers, shellcheck, Buildkite schema validation, and DCO sign-off.
  • Add tools/pre_commit/ helpers and .markdownlint.yaml / [tool.mypy]; expose render_test_pipeline for schema checks.

Test plan

  • pre-commit install then commit a small change and confirm hooks run on staged files only
  • Open/update this PR and confirm GitHub pre-commit workflow passes
  • Touch a .buildkite/*.yml file and confirm check-buildkite validates after render_test_pipeline
  • Touch a .sh / docs / Python file and confirm shellcheck / markdownlint / mypy / SPDX behave as expected

Test Result

eeb57fa6-80db-429a-9696-65b6c6ccd240

## Summary
- Introduced a new `.markdownlint.yaml` file to enforce markdown linting rules for documentation and READMEs.
- Updated `.pre-commit-config.yaml` to include various hooks for linting, formatting, and type checking, including:
  - YAML validation
  - Markdown linting
  - Shell script linting
  - Type checking with mypy for multiple Python versions
- Added new scripts for checking Buildkite YAML and ensuring SPDX headers are present in source files.

## Test Plan
- [ ] Verify that pre-commit hooks run successfully on changed files.
- [ ] Ensure markdown files adhere to the specified linting rules.
- [ ] Confirm that all new scripts function as intended.

Signed-off-by: [Your Name] <[Your Email]>
Signed-off-by: wangyu <410167048@qq.com>
@jiangkuaixue123
jiangkuaixue123 merged commit b00e884 into vllm-project:main Aug 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants