gui: fix Linux portal dialog response handling#70
Merged
Conversation
GGRei
force-pushed
the
fix-linux-portal-dialog-response
branch
from
23eb60d to
5b96ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Linux native file dialog freezes when the XDG Portal response is emitted on the real request handle instead of the guessed handle path.
The Linux portal backend now reads the request handle returned by the portal call, waits for
Responseon that exact object path, and keeps the previous convention-path handling as the pre-installed match to avoid fast-response races.Fix #69
Codex review validation : here
Validation
git diff --checkv fmt -verify nativebridge/_linux_backend_test.vv test nativebridge/_linux_backend_test.vv test nativebridgev test _native_dialog_test.v _window_queue_test.v _window_refresh_test.vv -path "/tmp|@vlib|@vmodules" -W -o /tmp/gui_issue69_dialogs_compile_check /tmp/gui/examples/dialogs.vnative_open_dialog()cancel no longer freezes the app