test: refactor coverage snapshot tests#7762
Merged
AriPerkkio merged 1 commit intoMar 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the coverage snapshot tests to compare coverage summaries rather than full coverage maps.
- Updates the pre-transpiled source test to use inline snapshots for verifying the list of files and file coverage details.
- Modifies the bundled sources test to import and use a new summary formatting function and verifies coverage summaries via inline snapshots.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/coverage-test/test/pre-transpiled-source.test.ts | Replaces multiple file-existence assertions with an inline snapshot, and adds inline snapshots for file coverage details based on coverage provider. |
| test/coverage-test/test/bundled-sources.test.ts | Updates import statements to include formatSummary; replaces multiple file-existence assertions with an inline snapshot; and validates coverage summaries for bundled sources across providers. |
Files not reviewed (4)
- test/coverage-test/test/snapshots/bundled-istanbul.snapshot.json: Language not supported
- test/coverage-test/test/snapshots/bundled-v8.snapshot.json: Language not supported
- test/coverage-test/test/snapshots/pre-transpiled-istanbul.snapshot.json: Language not supported
- test/coverage-test/test/snapshots/pre-transpiled-v8.snapshot.json: Language not supported
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compare coverage summaries instead of coverage maps.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.