Repository navigation
fix(rolldown): make run build record sessions and exit cleanly - #609
Open
webfansplz wants to merge 1 commit into
Open
webfansplz wants to merge 1 commit into
webfansplz wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The environment-gated integration addresses both reported failure modes with focused regression tests.
0 open findings
What changed in this PR
Enables Rolldown-triggered builds to record sessions under apply: "serve" while avoiding a standalone server that prevents clean exit.
Changes:
- Shares the Rolldown build environment marker through the kit.
- Enables build instrumentation when that marker is present.
- Skips standalone startup and adds regression coverage.
| File | Description |
|---|---|
packages/kit/src/constants.ts |
Exports the shared environment marker. |
packages/core/src/node/config.ts |
Enables marked Rolldown builds. |
packages/core/src/node/plugins/integration.ts |
Prevents standalone startup for marked builds. |
packages/core/src/node/__tests__/config.test.ts |
Tests environment-based enablement. |
packages/core/src/node/__tests__/integration.test.ts |
Tests integration loading and clean exit. |
packages/rolldown/src/node/plugin.ts |
Uses the shared marker. |
packages/rolldown/src/node/rolldown/build-runner.ts |
Uses the shared marker for child builds. |
packages/rolldown/src/node/rolldown/__tests__/build-runner.test.ts |
Updates test imports. |
test/__snapshots__/tsnapi/@vitejs/devtools-kit/constants.snapshot.js |
Records the JavaScript API export. |
test/__snapshots__/tsnapi/@vitejs/devtools-kit/constants.snapshot.d.ts |
Records the type API export. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #602