Repository navigation
fix(vite): include no-result transform hooks in module timings - #599
Merged
webfansplz merged 1 commit intoOct 9, 2026
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
SaKaNa-Y
force-pushed
the
fix/vite-no-result-transform-timing
branch
from
October 7, 2026 06:19
5a951f9 to
406dc44
Compare
This was referenced Oct 7, 2026
SaKaNa-Y
marked this pull request as ready for review
October 8, 2026 08:13
Collaborator
Author
|
Actually, all three PRs fix missing hook timings in specific cases. #599 fixes the issue where time spent in #606 fixes the issue where time spent in #607 fixes the issue where time spent in |
webfansplz
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
When investigating slow module processing in the Vite module graph, a plugin can appear cheaper than its recorded calls. A
transformhook can spend time on a module and returnundefinedornullto keep the input code. Plugin details record that time, but the module summary filters out transforms without a code result.Include all recorded transforms in the module summary. This preserves the existing code results and module sizes while counting the time spent in hooks that return no code.
Related fixes: #606 includes timings from
loadhooks that return no code. #607 includes timings from successfulresolveIdcalls that return the input ID. Each PR targetsmainand can be reviewed and merged independently.Validation on this branch:
undefinedandnullwith the old aggregation. They pass with this change. Unchanged code, changed code, and an empty string also pass.pnpm test --run: 52 files passed, 356 tests passed, 2 skipped.pnpm lint,pnpm typecheck, andpnpm buildpassed.