Repository navigation
fix(provider): make Claude SDK opt-in #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
861ce7f
fix(provider): load Claude SDK only when needed
onmax 67dac52
fix(provider): cancel delayed Claude startup
onmax 679a037
fix(provider): make Claude SDK opt-in
onmax 78dbd52
chore(provider): preserve package metadata
onmax ace4e6c
fix(provider): avoid pnpm peer auto-install
onmax 05da57b
fix(provider): keep Claude SDK optional after packaging
onmax 1248f5d
fix(desktop): stage lazy Claude SDK
onmax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import type * as ClaudeAgentSdk from "@anthropic-ai/claude-agent-sdk"; | ||
|
|
||
| const CLAUDE_AGENT_SDK_PACKAGE = ["@anthropic-ai", "claude-agent-sdk"].join( | ||
| String.fromCharCode(47), | ||
| ); | ||
|
|
||
| export function importClaudeAgentSdk(): Promise<typeof ClaudeAgentSdk> { | ||
| return import(/* @vite-ignore */ CLAUDE_AGENT_SDK_PACKAGE) as Promise<typeof ClaudeAgentSdk>; | ||
| } | ||
13 changes: 13 additions & 0 deletions
13
apps/server/src/provider/Layers/ClaudeAdapter.lazy.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { describe, expect, it, vi } from "vite-plus/test"; | ||
|
|
||
| vi.mock("@anthropic-ai/claude-agent-sdk", () => { | ||
| throw new Error("Claude SDK loaded eagerly."); | ||
| }); | ||
|
|
||
| describe("ClaudeAdapter module loading", () => { | ||
| it("does not load the Claude SDK while importing the adapter", async () => { | ||
| await expect(import("./ClaudeAdapter.ts")).resolves.toMatchObject({ | ||
| makeClaudeAdapter: expect.any(Function), | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.