Repository navigation
fix(viewer): give a narrow video player's seek bar its own row above the buttons - #91
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request b5ea05f3-5914-4c88-ae81-c92973ad1316. Ready; no repair needed. Inspected the complete diff and all supplied review bodies; Pullfrog and Codex report no findings, and current-head checks passed. Direct node_modules/.bin/vp fmt --check and vp lint passed for ViewerVideo.vue; Tailwind compilation confirmed the 448px and 672px container breakpoints. Browser validation could not run because Playwright’s Chromium executable is absent. The working tree remains clean. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes in ViewerVideo.vue, including the player-scoped responsive breakpoints and their interaction with Media Chrome's control-bar layout.
- Player-width responsiveness — Makes
media-controllera Tailwind container so controls adapt to the rendered player rather than the viewport. - Narrow seek layout — Moves the seek range to a full-width row and hides the volume slider below 672 px.
- Small-player controls — Hides the ±10-second buttons below 448 px while preserving play, time, mute, speed, and fullscreen controls.
- Wide layout preservation — Restores the existing single-row seek and volume controls at 672 px and wider.
gpt-5.6-sol | 𝕏

On a phone the video viewer's control bar was squashed: the seek bar shared one row with nine buttons, the time and the volume slider, so it got 80 px at a 520 px player, and at 327 px (a 375 px phone) the row ran past the edge and cut off the last buttons.
The bar now follows the player's own width, through a container query on
media-controller:The seek bar grows from 80 px to 325 px at 327 px, and from 80 px to 518 px at 520 px.
Checked in Chromium with Drop's media-chrome and the component's Tailwind classes compiled by Drop's Tailwind, at three player widths.
vp fmt --checkandvp lintpass on the file.Seek track and Markdown players. The track was
--borderon the bar and barely showed; it's now the foreground at 25%, as in comark-media.comark-uimoves to onmax/comark-ui#276's pkg.pr.new build (3d0d536), so a narrow video or audio player in a Markdown drop gets the same seek bar row and track. That build also has onmax/comark-ui#274, the zoomed screenshot's Copy in the zoom header, so thecomark-annotate@0.7.2patch that backported it is removed. It also brings the other comark-ui commits merged since the old pin (v0.7.3 and v0.7.4).vp test(378 passed) andnuxt typecheckpass.