Skip to content

Add password strength validation for signup#503

Open
C4aZy wants to merge 2 commits into
viru0909-dev:mainfrom
C4aZy:feat/Password-Strength
Open

Add password strength validation for signup#503
C4aZy wants to merge 2 commits into
viru0909-dev:mainfrom
C4aZy:feat/Password-Strength

Conversation

@C4aZy
Copy link
Copy Markdown

@C4aZy C4aZy commented May 20, 2026

Pull Request

Description

Made the password strength stronger and made the password more than 8 characters rather than 6 characters.
Closes #476

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@C4aZy C4aZy requested a review from viru0909-dev as a code owner May 20, 2026 14:16
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

@C4aZy is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel.

A member of the Team first needs to authorize it.

@C4aZy
Copy link
Copy Markdown
Author

C4aZy commented May 20, 2026

@viru0909-dev Please review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nyaysetu Ready Ready Preview, Comment May 21, 2026 9:20am

Copy link
Copy Markdown
Owner

@viru0909-dev viru0909-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C4aZy The PR looks safe and beneficial overall — good security enhancement, improved UX, and the dual-layer validation is implemented correctly.

There is just one small must-fix issue before merging: in RegisterRequest.java, the validation error message still says "6 characters" while the actual requirement is 8 characters. Please update the message accordingly.

@C4aZy This should be a quick 2-minute fix. Once updated, the PR will be ready to merge.

@C4aZy
Copy link
Copy Markdown
Author

C4aZy commented May 21, 2026

@viru0909-dev Fixed it.Please review.
Screenshot 2026-05-21 at 6 43 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add Password Strength Rules and Validation

2 participants