Summary: Add docker support. by hasbegun · Pull Request #47 · vircadia/vircadia-web

hasbegun · 2022-02-08T09:06:29Z

Create a docker image. It checks out vircadia-web-sdk,
compile and install for vircadia-web.
Port 8080 is open for the service.
This image can be used as a port of docker-compose at
vircadia-domain-server-docker.

Create a docker image. It checks out vircadia-web-sdk, compile and install for vircadia-web. Port 8080 is open for the service. This image can be used as a port of docker-compose at vircadia-domain-server-docker.

Misterblue

Looking good. This built and, after some tweaking, worked.

Misterblue · 2022-02-13T17:20:45Z

docker/Dockerfile

@@ -0,0 +1,62 @@
+FROM ubuntu:20.04 as web-base
+
+RUN apt update && apt install -y git curl


Should use apt-get instead of plain apt to get rid of the warning "WARNING: apt does not have a stable CLI interface. Use with caution in scripts."

Misterblue · 2022-02-13T17:21:51Z

docker/Dockerfile

@@ -0,0 +1,62 @@
+FROM ubuntu:20.04 as web-base
+
+RUN apt update && apt install -y git curl


RUN apt-get update && apt-get upgrade && apt-get install -y git curl
That is, shouldn't there be an "upgrade" after the "update"?

yeah... it doesn't hurt.

Misterblue · 2022-02-13T17:22:42Z

docker/Dockerfile

+    rm ./nodesource_setup.sh
+
+FROM web-base as web-sdk-builder
+RUN apt update


Is this 'update' necessary since it was done in the base image?

yeah... drop it.

Misterblue · 2022-02-13T17:26:10Z

docker/Dockerfile

+FROM web-base as web-sdk-builder
+RUN apt update
+# checkout repo
+RUN mkdir -p /usr/local/src && \


Since Docker layer caching might use a cached layer even if the v-web sources have changed, adding a ADD https://api.github.com/repos/vircadia/vircadia-web/git/refs/heads/master vircadia-web-git-version.json before this RUN will break the cache if the sources have changed.

Good idea!!! Add this line.

Adding this line causes an error like following:

21 40.93 npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
#21 41.21 npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
#21 50.11 npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
#21 71.51 npm ERR! code ERR_SOCKET_TIMEOUT
#21 71.51 npm ERR! network Socket timeout
#21 71.51 npm ERR! network This is a problem related to network connectivity.

Any idea why?

I saw those errors also but figured they were related to v-web-sdk configuration/versioning. Maybe need a revisit of the v-web-sdk build independent of the Docker image. Wonder what v-web-sdk has for package-lock and other requirements.

Misterblue · 2022-02-13T17:28:44Z

docker/Dockerfile

+
+RUN apt update && apt install -y sudo vim
+RUN usermod -aG sudo ${USER} && \
+    echo '%sudo ALL=(ALL) NOPASSWD: ALL' >> /etc/sudoers && \


Not sure adding to sudo. If this is a deployed version, the whole point of creating a user to run the app is so there run environment is somewhat safe. Maybe have some "debug build" option?

No it is only dev and debug. Will comment it out.

What would be the proper command to run the app?
I split build
web-base
| - ubuntu20.04
| - node 16, quasar, and vue
|- web-sdk-build => produces vircadia-web-sdk-2022.1.2.tgz
|- web-build => build app
|- web-run => run app
- create cadia user,
- copy /usr/local/src/vircadia-web/package*.json /home/cadia/vircadia-web
- copy /usr/local/src/vircadia-web/dist /home/cadia/vircadia-web/dist
- Run npm install --production
This will remove "sudo".
Can you recommend me a command line that runs the app?

Misterblue · 2022-02-13T17:39:16Z

docker/Dockerfile

+RUN apt update && apt install -y git curl
+RUN curl -sL https://deb.nodesource.com/setup_14.x -o nodesource_setup.sh && \
+    bash ./nodesource_setup.sh && \
+    apt install nodejs && \


This installs NodeJS v14. The SDK's package-lock.json is version 2 which implies NodeJS v16. There are some warning because of this. Might need to use NVM or similar to get a different NodeJS version.
Also, v-web-sdk should probably have an "engine:" section added to its package.json.

I was wondering what would be the right. if so, let's update to 16.

Misterblue · 2022-02-13T17:44:12Z

docker/run-docker-vircadia-web.sh

+
+DVERSION=latest
+
+docker run -it --rm \


When I first ran the image, I got the error:

vircadia@nyxx:~/vircadia-web-mb/docker> ./run-docker-vircadia-web.sh Log file: /home/cadia/vircadia-web/log/20220213.1741.log /home/cadia/run-vircadia-web.sh: line 16: /home/cadia/vircadia-web/log/20220213.1741.log: Permission denied vircadia@nyxx:~/vircadia-web-mb/docker>

which says that the mounted log directory didn't have the permissions to create files in the mounted directory.
This run file should check and/or change the permissions of the target log directory to allow the Docker account "cadia" to write into the mounted dir.

ok. need to change how it runs the app. For now it requires sudo. I am going to drop 'sudo' and move app to /home/cadia. Let me do it.

Misterblue · 2022-02-13T17:55:48Z

docker/run-docker-vircadia-web.sh

+    -p 8080:8080 \
+    -p 8081:8081 \
+    -p 8082:8082 \
+    --volume ${BASE}/log:/home/cadia/vircadia-web/log \


There should be a "--detach" to run the container as a service in the background.

Misterblue · 2022-02-13T17:56:28Z

docker/run-docker-vircadia-web.sh

+    -p 8080:8080 \
+    -p 8081:8081 \
+    -p 8082:8082 \
+    --volume ${BASE}/log:/home/cadia/vircadia-web/log \


Since this is to be a service, add a "--restart=unless-stopped"

Misterblue · 2022-02-13T17:58:53Z

src/config.ts


 export const DefaultConfig: { [key: string]: string } = {
    "Default_Metaverse_Url": "https://metaverse.vircadia.com/live",
+    // docker compose metaverse


Enhance this comment to say this is a debugging option.

Yep. will update the comment.

digisomni · 2022-03-05T19:08:28Z

This PR has a merge conflict. :)

Summary: Add docker support.

3f7f8b6

Create a docker image. It checks out vircadia-web-sdk, compile and install for vircadia-web. Port 8080 is open for the service. This image can be used as a port of docker-compose at vircadia-domain-server-docker.

digisomni requested review from Misterblue and digisomni February 10, 2022 22:23

Misterblue suggested changes Feb 13, 2022

View reviewed changes

digisomni force-pushed the master branch 2 times, most recently from d0c6125 to 507ff53 Compare July 4, 2022 14:12

younianhuang force-pushed the master branch 3 times, most recently from c0e1bda to b120d11 Compare September 5, 2022 09:43

		@@ -0,0 +1,62 @@
		FROM ubuntu:20.04 as web-base

		RUN apt update && apt install -y git curl

Conversation

hasbegun commented Feb 8, 2022

Uh oh!

Misterblue left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hasbegun Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

digisomni commented Mar 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

hasbegun Feb 14, 2022 •

edited

Loading